From 434e3d136503d36f0d41108ae5942fdb8935259e Mon Sep 17 00:00:00 2001
From: Elliott Hughes <enh@google.com>
Date: Mon, 2 Oct 2023 18:57:05 +0000
Subject: Move off test_per_src.

It's badly supported and unmaintained. We can't use these "tests" in
TEST_MAPPING anyway, since they're not actually unit tests, but I never
like leaving bad ideas lying around for others to copy & paste...

Bug: http://b/293945424
Test: treehugger
Change-Id: I69164cc4d0f3414d4823792c8ea02be904048569
---
 Android.bp | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 70 insertions(+), 15 deletions(-)

diff --git a/Android.bp b/Android.bp
index 37d6227f..258a027c 100644
--- a/Android.bp
+++ b/Android.bp
@@ -86,25 +86,80 @@ cc_library {
 }
 
 //
-// Tests.
+// Tests (but not _unit_ tests).
+//
+// It's unlikely anyone's running these manually, but at least compiling them
+// shows we can compile libpcap callers...
 //
 
 cc_test {
-    name: "libpcap_test",
+    name: "libpcap_can_set_rfmon_test",
     defaults: ["libpcap_defaults"],
     gtest: false,
-    // (Matches order in libpcap's Makefile.)
-    srcs: [
-        "testprogs/can_set_rfmon_test.c",
-        "testprogs/capturetest.c",
-        "testprogs/filtertest.c",
-        "testprogs/findalldevstest.c",
-        "testprogs/opentest.c",
-        "testprogs/reactivatetest.c",
-        "testprogs/selpolltest.c",
-        "testprogs/threadsignaltest.c",
-        "testprogs/valgrindtest.c",
-    ],
+    srcs: ["testprogs/can_set_rfmon_test.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_capture_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/capturetest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_filter_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/filtertest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_findalldevs_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/findalldevstest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_open_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/opentest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_reactivate_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/reactivatetest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_selpoll_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/selpolltest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_threadsignal_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/threadsignaltest.c"],
+    static_libs: ["libpcap"],
+}
+
+cc_test {
+    name: "libpcap_valgrind_test",
+    defaults: ["libpcap_defaults"],
+    gtest: false,
+    srcs: ["testprogs/valgrindtest.c"],
     static_libs: ["libpcap"],
-    test_per_src: true,
 }
-- 
cgit v1.2.3