Fix handling of "--reporter" CLI parameter

2 files changed, 61 insertions, 1 deletions

diff --git a/ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt b/ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
index 8aab056c..59d8db4f 100644
--- a/ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
+++ b/ktlint-cli/src/main/kotlin/com/pinterest/ktlint/cli/internal/KtlintCommandLine.kt
@@ -165,7 +165,7 @@ internal class KtlintCommandLine :
                 "A reporter to use (built-in: plain (default), plain?group_by_file, plain-summary, json, sarif, checkstyle, html). To use" +
                     "a third-party reporter specify a path to a JAR file on the filesystem via ',artifact=' option. To override reporter " +
                     "output, use ',output=' option.",
-        ).split(",").default(emptyList())
+        ).multiple()
 
     private val rulesetJarPaths: List<String> by
         option(
diff --git a/ktlint-cli/src/test/kotlin/com/pinterest/ktlint/cli/SimpleCLITest.kt b/ktlint-cli/src/test/kotlin/com/pinterest/ktlint/cli/SimpleCLITest.kt
index 5bd0efb6..bae6194f 100644
--- a/ktlint-cli/src/test/kotlin/com/pinterest/ktlint/cli/SimpleCLITest.kt
+++ b/ktlint-cli/src/test/kotlin/com/pinterest/ktlint/cli/SimpleCLITest.kt
@@ -232,6 +232,66 @@ class SimpleCLITest {
     }
 
     @Test
+    fun `Issue 2576 - single reporter`(
+        @TempDir
+        tempDir: Path,
+    ) {
+        CommandLineTestRunner(tempDir)
+            .run(
+                "too-many-empty-lines",
+                listOf("**/*.test", "--reporter=plain"),
+            ) {
+                SoftAssertions()
+                    .apply {
+                        assertErrorExitCode()
+                        assertThat(normalOutput)
+                            .containsLineMatching("Main.kt.test:2:1: First line in a method block should not be empty")
+                    }.assertAll()
+            }
+    }
+
+    @Test
+    fun `Issue 2576 - multiple reporters`(
+        @TempDir
+        tempDir: Path,
+    ) {
+        CommandLineTestRunner(tempDir)
+            .run(
+                "too-many-empty-lines",
+                listOf("**/*.test", "--reporter=plain", "--reporter=json,output=ktlint-violations.json"),
+            ) {
+                SoftAssertions()
+                    .apply {
+                        assertErrorExitCode()
+                        assertThat(normalOutput)
+                            .containsLineMatching("Initializing \"plain\" reporter")
+                            .containsLineMatching(Regex(".*Initializing \"json\" reporter with .*, output=ktlint-violations.json"))
+                            .containsLineMatching("Main.kt.test:2:1: First line in a method block should not be empty")
+                            .containsLineMatching(Regex(".*ReporterAggregator -- \"json\" report written to .*ktlint-violations.json"))
+                    }.assertAll()
+            }
+    }
+
+    @Test
+    fun `Given a custom reporter which does not exist`(
+        @TempDir
+        tempDir: Path,
+    ) {
+        CommandLineTestRunner(tempDir)
+            .run(
+                "too-many-empty-lines",
+                listOf("**/*.test", "--reporter=custom,artifact=custom-reporter.jar"),
+            ) {
+                SoftAssertions()
+                    .apply {
+                        assertErrorExitCode()
+                        assertThat(normalOutput)
+                            .containsLineMatching("File 'custom-reporter.jar' does not exist")
+                    }.assertAll()
+            }
+    }
+
+    @Test
     fun `Generate git pre commit hook`(
         @TempDir
         tempDir: Path,