aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
4 daysSnap for 11880863 from c010856fca706e2ce547f15df8972f1756160a65 to ↵build-tools-releaseAndroid Build Coastguard Worker
build-tools-release Change-Id: If1a0ccccda285aeeb2c7456309ea24ee4dad49ec
5 daysUpgrade ktfmt to v0.49HEADmastermainJordan Demeulenaere
This project was upgraded with external_updater. Usage: tools/external_updater/updater.sh update external/ktfmt For more info, check https://cs.android.com/android/platform/superproject/+/main:tools/external_updater/README.md Test: TreeHugger Change-Id: I18026d8711938f9bd06e2ef38b6b9ad4847230fe
2024-04-24Bump version to 0.49Nivaldo Bondança
Reviewed By: strulovich Differential Revision: D56503355 fbshipit-source-id: 2befbe9ddb60d6284f9dc277e860796bc4a81ed6
2024-04-24Fixed param usageNivaldo Bondança
Summary: Based on this here https://github.com/kubevirt/hyperconverged-cluster-operator/blob/54462873dd1cb42da28296c5bb3b6dbb8ede37ec/.github/workflows/build-push-images.yaml#L28 Hopefully things work this time. Previous failure => https://github.com/facebook/ktfmt/actions/runs/8820750772/workflow Reviewed By: cortinico Differential Revision: D56528305 fbshipit-source-id: 78cbc46f332e677f56db881f960041528cf76c21
2024-04-24Add params to workflowNivaldo Bondança
Summary: By itself this other diff didn't work, {D56474962} https://github.com/facebook/ktfmt/actions/runs/8810035537/job/24181770243#step:5:53 Trying another method now Reviewed By: cortinico Differential Revision: D56512721 fbshipit-source-id: f95bbb91ae316e62b3904f007de7b5e9c2acbd11
2024-04-23Add workflow_dispatch to be able to manually retrigger a release.Nicola Corti
Summary: 0.48 failed to publish, this should allow us to re-trigger this release. Reviewed By: hick209 Differential Revision: D56474962 fbshipit-source-id: 45440599ccb5e26bacb19b9f6c01f4da5beb0cfe
2024-04-23Pointing Gradle deps to use latest stable version of ktfmtNivaldo Bondança
Summary: Right now things are broken as is since we don't update snapshot versions of ktfmt to maven. My proposal is to use the latest available stable version when compiling them. Likely not optimal, but at least should reduce the curernt amount of headaches. Issues: ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileKotlin'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find com.facebook:ktfmt:0.49-SNAPSHOT. ``` and ``` FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileJava'. > Could not resolve all files for configuration ':compileClasspath'. > Could not find com.facebook:ktfmt:0.49. ``` Reviewed By: cortinico Differential Revision: D56472377 fbshipit-source-id: 509620821be40353c10e41f72670de5567792915
2024-04-23Stop emitting multiple trailing commas in enum entry lists with multiline ↵nickreid
items (#458) Summary: Pull Request resolved: https://github.com/facebook/ktfmt/pull/458 Reviewed By: cortinico Differential Revision: D56467830 Pulled By: hick209 fbshipit-source-id: 0d97ccb01cfa8436443db27ec244a2759a57251d
2024-04-23Bump version to 0.49-SNAPSHOTNivaldo Bondança
Reviewed By: cortinico Differential Revision: D56467598 fbshipit-source-id: 461cf597e828cf15543655febc4e96c88ee67b7d
2024-04-23Bump version to 0.48Nivaldo Bondança
Summary: Changelog: * Migrated to Google Java Format 1.22.0 (https://github.com/facebook/ktfmt/pull/440 and https://github.com/facebook/ktfmt/pull/452) * Added support for RangUntil (`..<`) operator (https://github.com/facebook/ktfmt/pull/433) * Trailing space issue on lambda blocks (https://github.com/facebook/ktfmt/pull/426) * Fix empty enum parse error (https://github.com/facebook/ktfmt/pull/425) * Preserving empty enums semicolons (https://github.com/facebook/ktfmt/pull/434) * Always use UTF8 (https://github.com/facebook/ktfmt/pull/437) * IntelliJI DEA plugin update (https://github.com/facebook/ktfmt/pull/420) * Managing trailing commas in enums (https://github.com/facebook/ktfmt/pull/449) * Badges on README (https://github.com/facebook/ktfmt/pull/446 and https://github.com/facebook/ktfmt/pull/453) * Emit parsing error for calls with multiple trailing lambdas (https://github.com/facebook/ktfmt/pull/457) * Removed duplicated line in editorconfig file (https://github.com/facebook/ktfmt/pull/456) Reviewed By: cortinico Differential Revision: D56467599 fbshipit-source-id: 10e90a34118267e36db80940f6a4e43aef89fbd3
2024-04-22Update ktfmt component on FBS:master (#44184)Nivaldo Bondança
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44184 Reviewed By: zertosh Differential Revision: D56421174 fbshipit-source-id: 686e23775f53d67980c2e84a17d0a5c490dbec2a
2024-04-22Update google-java-format to 1.22.0 (#452)nickreid
Summary: This update adds support for multiline tokens, which fixes several bugs related to multiline strings. Pull Request resolved: https://github.com/facebook/ktfmt/pull/452 Reviewed By: cortinico Differential Revision: D55641796 Pulled By: hick209 fbshipit-source-id: ec0782c0d91ababe537866627c719cd3df7c6b54
2024-04-18Remove duplicated line in editorconfig for dropbox style (#456)sabufung
Summary: Remove `ij_java_names_count_to_use_import_on_demand = 9999` in `.editorconfig-dropbox` Pull Request resolved: https://github.com/facebook/ktfmt/pull/456 Reviewed By: cortinico Differential Revision: D56152253 Pulled By: hick209 fbshipit-source-id: 6c01241429eda27e33b5c40637d2a063167f6afb
2024-04-15Emit a parsing error for calls with multiple trailing lambdas (#457)nickreid
Summary: Pull Request resolved: https://github.com/facebook/ktfmt/pull/457 Reviewed By: strulovich Differential Revision: D56153379 Pulled By: hick209 fbshipit-source-id: c4b264e5251c15e8855e7fe9447458c49efe74d6
2024-04-11Redo of D55330950: Preserve a trailing space when lambda only has block commentsNivaldo Bondança
Summary: This redoes what we accomplished on D55330950, but in a slightly different manner. There are still formatting weirdness going on which I would love to fix, but I haven't been able to do so yet Reviewed By: cortinico Differential Revision: D55470556 fbshipit-source-id: de9edc912da88ff3086b01352496bdb778b25e56
2024-04-11Added tests for lambda block formattingNivaldo Bondança
Summary: Some of those here should be fixed on the next diff. I found it clearer to do like this so we can clearly see what the changes are doing and changing behavior (before vs after). Reviewed By: cortinico Differential Revision: D55470473 fbshipit-source-id: 50935fa938d045228ced7e2d4f41f2e81469ef94
2024-04-04facebookincubator --> facebookNivaldo Bondança
Summary: No longer a project under facebookincubator and it's been like that for a while now. Let's adjust the URLs accordingly. Reviewed By: strulovich Differential Revision: D55759910 fbshipit-source-id: 173d1a98cd088895f0818e517d8b5289df969378
2024-04-04Fixed badges on README.md (#453)Nivaldo Bondança
Summary: Fixed build status badge and added release and issue count ones as well. BTW, I used [this awesome tool here](https://michaelcurrin.github.io/badge-generator/#/repo) to generate the badges. Thanks MichaelCurrin Pull Request resolved: https://github.com/facebook/ktfmt/pull/453 Reviewed By: cortinico Differential Revision: D55705080 Pulled By: hick209 fbshipit-source-id: 4a00dd448cab3e7dcdf571b3f392ba42c6a4af07
2024-04-03Fix build failure due to file format mismatchNivaldo Bondança
Summary: Make sure to use same version of Google Java Format that we use to format our code. This will avoid the isses we can [see here](https://github.com/facebook/ktfmt/actions/runs/8529628883/job/23365788968#step:5:515) and below ``` FAILURE: Build failed with an exception. ... * What went wrong: Execution failed for task ':spotlessJavaCheck'. > The following files had format violations: src/main/java/com/facebook/ktfmt/intellij/KtfmtConfigurable.java @@ -200,9 +200,7 @@ ············false)); ··} -··/** -···*·noinspection·ALL -···*/ +··/**·noinspection·ALL·*/ ··public·JComponent·$$$getRootComponent$$$()·{ ····return·panel; ··} Run './gradlew :spotlessApply' to fix these violations. ... BUILD FAILED in 2m 6s Error: Process completed with exit code 1. ``` Reviewed By: cortinico Differential Revision: D55698986 fbshipit-source-id: 9b6a0a9ba1acbd64baf79f1d66ff17d948dfb657
2024-04-03Add Slack channel badge to the README (#448)Javier Segovia Córdoba
Summary: This PR only adds a badge with the link to the ktmft Slack channel in Kotlinlang. > [!Warning] > The Facebook build badge is broken, if not, they would appear inline. Pull Request resolved: https://github.com/facebook/ktfmt/pull/448 Reviewed By: hick209 Differential Revision: D55482265 Pulled By: cortinico fbshipit-source-id: 16ccf68a6504fc221f221f7c8425ba4e30258b69
2024-04-02Update line width markerNivaldo Bondança
Summary: Make it so we can use something that will not mess up with Kotlin syntax (no reds) Reviewed By: cortinico Differential Revision: D55528436 fbshipit-source-id: eab42d0dda5acef3f8c39ce1bfa30c0787c4a361
2024-04-02Kotlin languageNivaldo Bondança
Summary: IDE syntax highlighting for test code Reviewed By: cortinico Differential Revision: D55527060 fbshipit-source-id: b00f6f24fdce6711f8c9e603ed5890b5d2d31b13
2024-04-02Automatically manage trailing commas in enums (#449)nickreid
Summary: Pull Request resolved: https://github.com/facebook/ktfmt/pull/449 Reviewed By: cortinico Differential Revision: D55495213 Pulled By: hick209 fbshipit-source-id: cfa075efd2096af3eea51f0a232260b049ab12d4
2024-04-02Extracted helper PSI related operations into its own fileNivaldo Bondança
Summary: No logic changes, just moving code around Reviewed By: cortinico Differential Revision: D55526890 fbshipit-source-id: 376265c425bda61867fb7c6cad7aefd7e6871a2e
2024-04-02Just reformat and organize Tokenizer fileNivaldo Bondança
Summary: No actual changes other than reorganizing things Reviewed By: cortinico Differential Revision: D55526882 fbshipit-source-id: 1b7a6dc5bf76696fdbb6ac20b47e069347f05012
2024-04-02Fix gradle build of ktfmt_idea_pluginNivaldo Bondança
Reviewed By: cortinico Differential Revision: D55635633 fbshipit-source-id: 0f327282682507c2744d27991a3b764dbdae5366
2024-04-02Add toString to FenceCommentsOpNivaldo Bondança
Reviewed By: cortinico Differential Revision: D55521098 fbshipit-source-id: 6d3713ac13c0661a7a44016133a02c1950dd7bbd
2024-03-28Simple fixes to KtfmtTruthNivaldo Bondança
Summary: I noticed the error didn't make sense which was a head scratcher until I noticed things the messages were flipped. After that I still had an issue since my test did not have any `-` but it was still flagging as if it did. That's when I noticed that the `all` method returns `true` for empty strings. ``` public inline fun CharSequence.all(predicate: (Char) -> Boolean): Boolean { for (element in this) if (!predicate(element)) return false return true } ``` Reviewed By: cortinico Differential Revision: D55438892 fbshipit-source-id: 264779e7b92aae2790d9c41e047790f31bc7cff0
2024-03-27Revert D55330950: Preserve a trailing space when lambda only has block commentsNivaldo Bondança
Differential Revision: D55330950 Original commit changeset: ca9288b3b1b4 Original Phabricator Diff: D55330950 fbshipit-source-id: 3fb64d1aa01764d358154ac9b5747ea45d99cd04
2024-03-27Update ktfmt plugin for IntelliJ IDEA (#420)Peter Laggner
Summary: Changes: - update build dependencies - gradle wrapper - intellij gradle plugin - use `AsyncDocumentFormattingService` implementation to format code with `ktfmt` (adjusted from `google-java-format` IDEA plugin) ~~Intended to fix https://github.com/facebook/ktfmt/issues/399~~ (IDEA plugin seems to have been published for `0.46`) Pull Request resolved: https://github.com/facebook/ktfmt/pull/420 Reviewed By: davidtorosyan Differential Revision: D55315138 Pulled By: hick209 fbshipit-source-id: 79b2f387e687dfee23b4d80147c69272a202515e
2024-03-27Always use UTF8 as the encoding for Kotlin code, regardless of the ↵nickreid
system/default charset (#437) Summary: Closes https://github.com/facebook/ktfmt/issues/373 Pull Request resolved: https://github.com/facebook/ktfmt/pull/437 Reviewed By: cortinico Differential Revision: D55365174 Pulled By: hick209 fbshipit-source-id: 008d21121a916a8bc9fb4f2524b66f75683a2c6a
2024-03-26Preserve semicolons in enums with members but no entries (#434)nickreid
Summary: Inspired by https://github.com/facebook/ktfmt/pull/425 Pull Request resolved: https://github.com/facebook/ktfmt/pull/434 Reviewed By: davidtorosyan Differential Revision: D55315262 Pulled By: hick209 fbshipit-source-id: df1578f253aa30adc0f1ecd8c9e7ee2f061b36a7
2024-03-26Fix parse error on empty enum with semicolons (#425)Fredy Wijaya
Summary: This fixes https://github.com/facebook/ktfmt/issues/422. Pull Request resolved: https://github.com/facebook/ktfmt/pull/425 Reviewed By: davidtorosyan Differential Revision: D55315114 Pulled By: hick209 fbshipit-source-id: 367e9b5f8a502eb84e41bd4e90da5ab24f290269
2024-03-26Preserve a trailing space when lambda only has block comments (#426)Fredy Wijaya
Summary: This fixes https://github.com/facebook/ktfmt/issues/408 Pull Request resolved: https://github.com/facebook/ktfmt/pull/426 Reviewed By: davidtorosyan Differential Revision: D55330950 Pulled By: hick209 fbshipit-source-id: ca9288b3b1b42d0ae1003384ce9adc7d08f9c66d
2024-03-25Support RangeUntil operator (#433)Tim Winters
Summary: Fixes https://github.com/facebook/ktfmt/issues/424 Pull Request resolved: https://github.com/facebook/ktfmt/pull/433 Reviewed By: cortinico Differential Revision: D55314955 Pulled By: hick209 fbshipit-source-id: 8a3cb774cbbdbd800845a4e3a51e42dea20e1a37
2024-03-23Migrate google java format from 1.7 -> 1.21.0 (#440)Jeff Bahr
Summary: X-link: https://github.com/facebookexternal/OculusManufacturing/pull/524 X-link: https://github.com/facebookexternal/fbpay/pull/3 X-link: https://github.com/facebook/screenshot-tests-for-android/pull/324 X-link: https://github.com/pytorch/executorch/pull/1771 X-link: https://github.com/facebook/igl/pull/68 X-link: https://github.com/facebook/mariana-trench/pull/153 X-link: https://github.com/facebook/fresco/pull/2757 X-link: https://github.com/facebook/litho/pull/974 X-link: https://github.com/facebook/react-native/pull/42754 X-link: https://github.com/facebook/hhvm/pull/9431 X-link: https://github.com/WhatsApp/eqwalizer/pull/52 X-link: https://github.com/facebookincubator/spectrum/pull/1858 X-link: https://github.com/fbsamples/metapay/pull/1 X-link: https://github.com/facebookincubator/fbjni/pull/95 X-link: https://github.com/facebookincubator/Battery-Metrics/pull/30 Pull Request resolved: https://github.com/facebook/ktfmt/pull/440 X-link: https://github.com/facebook/flipper/pull/5456 X-link: https://github.com/facebook/hermes/pull/1290 X-link: https://github.com/facebook/TextLayoutBuilder/pull/35 X-link: https://github.com/facebook/SoLoader/pull/122 allow-large-files This diff migrates google java format form 1.7 to 1.21.0. This update will allow for new language features from java 17 and 21. This diff also formats all necessary files. Changelog: [Internal][Changed] - Updated format from google-java-format 1.7 -> 1.21.0 Reviewed By: IanChilds Differential Revision: D52786052 fbshipit-source-id: b675ae215084f340b93dfe628e329e696ca0616e
2024-03-15Snap for 11582845 from 60afc16436dbbe4bfe7a88a648d9360919a1775a to ↵Android Build Coastguard Worker
build-tools-release Change-Id: Iec0c57b4809039e10c8b8ae986285b717bf1994c
2024-01-22Snap for 11341804 from db33ff2a4833c9537be889a7819236d274d20a47 to ↵Android Build Coastguard Worker
build-tools-release Change-Id: I5080363f65f706e2014cc2bd780167a229f8201e
2024-01-17Bump version to 0.47-SNAPSHOTCarmi Grushko
Reviewed By: hick209 Differential Revision: D52814151 fbshipit-source-id: 0cbee70961eba7a19fac354c848e30b5525637aa
2024-01-17Bump version to 0.47Carmi Grushko
Reviewed By: hick209 Differential Revision: D52814152 fbshipit-source-id: 8e7c8341c1b2bbdd83d2d039200b022dcc4d1b0d
2023-11-13Reformat Kotlin filesgeneratedunixname89002005325672
Reviewed By: cgrushko Differential Revision: D51248035 fbshipit-source-id: b612b96612929732960977a4cda55209155e5438
2023-11-10Automatically manage trailing commas when running with --google-style (#427)nickreid
Summary: Commas are added/removed according to the following rules: - Lambda param lists => remove - Single element lists => remove - Lists that fit on one line => remove - All other lists (multiline lists) => add Pull Request resolved: https://github.com/facebook/ktfmt/pull/427 Reviewed By: davidtorosyan Differential Revision: D51115906 Pulled By: strulovich fbshipit-source-id: 2579591911a613efdb495c34a9c70270979af8a9
2023-10-05Snap for 10908379 from 67707de75aa6132d46b4fccd3da21bf1e47ad19c to ↵Android Build Coastguard Worker
build-tools-release Change-Id: I16ba2e016edb532eb6318bb32f153eb11bb83ba7
2023-09-21Add unit tests to capture line break behavior on type specifiersDavid Torosyan
Summary: It came up recently that this formatting (for the `where` case) looks weird and should probably be indented. To make sure we track any fixes (or just are aware that we've always had this issue) add a couple of unit tests. One to demonstrate the issue, the other to show a better case. Note that a previous change (D34347730) added a similar (but different) unit test. Reviewed By: hick209 Differential Revision: D49507677 fbshipit-source-id: 777eb3becf51d0061fea19953fd950a71d8fe36b
2023-09-18Plugin doesn't work with if "Only VCS changed text" is selected from ↵haruka
code-reformat settings (#386) Summary: Fixes facebook/ktfmt#228 The code reformat with "Only VCS changed text" falls back to the IDE Kotlin settings due to a missing override in KtfmtCodeStyleManager.java. This is also true of the popular "Save Actions" plugin which reformats with the same command. This change adds the missing override exactly as it appears in the reference project google/google-java-format at https://github.com/google/google-java-format/blob/d86e930de93f123994fba151a8d289b8035db87b/idea_plugin/src/com/google/googlejavaformat/intellij/GoogleJavaFormatCodeStyleManager.java#L76 Confirmed to fix the issue on Android Studio 2021.1.1 with the manual code-reformat and in the Save Actions plugin. Pull Request resolved: https://github.com/facebook/ktfmt/pull/386 Reviewed By: strulovich Differential Revision: D49322592 Pulled By: hick209 fbshipit-source-id: 99d56d428603292ffb6efb6551e7fa619367c0bd
2023-09-18Bump version to 0.47-SNAPSHOTNivaldo Bondança
Reviewed By: strulovich Differential Revision: D49381561 fbshipit-source-id: de0bf6758b4fbf2ffc5857e2d0687fdc0281f2a2
2023-09-18Bump version to 0.46Nivaldo Bondança
Reviewed By: strulovich Differential Revision: D49381562 fbshipit-source-id: 6f2188db281add318bf800ffd9e3e804f86caa29
2023-09-18Fix indentation of trailing comments in a bunch of cases (#418)nickreid
Summary: Pull Request resolved: https://github.com/facebook/ktfmt/pull/418 Reviewed By: strulovich Differential Revision: D49318446 Pulled By: hick209 fbshipit-source-id: 7ea64f7055f57adf665e6ad3912b3465f5386c95
2023-09-18Adjust .editorconfig for kotlinlang style for IntelliJ to better align with ↵Chris Lee
ktfmt (#412) Summary: Two changes: 1. Field annotations are set to wrap `off`, to align with ktfmt that places them on the same line as the field. e.g. ```kotlin get:Input internal abstract val versionPropertyName: Property<String> ``` ...will now match what ktfmt does: ```kotlin get:Input internal abstract val versionPropertyName: Property<String> ``` 2. Import order; IntelliJ places java.*, javax.*, kotlin.* at the end, after other imports, whereas ktfmt places all imports in alphabetical order: e.g. ```kotlin import org.gradle.api.file.FileSystemOperations import org.gradle.api.file.RegularFileProperty import org.gradle.api.model.ObjectFactory import org.gradle.api.provider.ListProperty import org.gradle.api.provider.Property import java.util.* import javax.inject.Inject ``` ... will now be consistent with ktfmt, all sorted alphabetically. ```kotlin import java.util.* import javax.inject.Inject import org.gradle.api.file.FileSystemOperations import org.gradle.api.file.RegularFileProperty import org.gradle.api.model.ObjectFactory import org.gradle.api.provider.ListProperty import org.gradle.api.provider.Property ``` Pull Request resolved: https://github.com/facebook/ktfmt/pull/412 Reviewed By: strulovich Differential Revision: D49319451 Pulled By: hick209 fbshipit-source-id: f2b6a163cd18ae3ec2f82227b6dd2f18eea11098
2023-09-18Bump Kotlin version to 1.8.22Nivaldo Bondança
Summary: This also required a bump on the Gradle version to 6.8.3, instead I just took the latest. Reviewed By: natestedman Differential Revision: D49326207 fbshipit-source-id: a4dcd301b7c5aac43cb75422c542b770928cd8fd
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-27 22:00:45 +0000