summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaslyn Tonelli <caslyn@google.com>2023-04-28 06:55:23 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2023-04-28 06:55:23 +0000
commite019f02f857252649b1fe9f0b30431a07ee0e8c8 (patch)
tree291c7f06270e61aae8244e857ac9c145f6b5d2f9
parent3d67343ede5580ae8042fc592038535e0f15ef91 (diff)
parent92529f313e5af8ec3519274e596edfdae65faada (diff)
downloadgwp_asan-e019f02f857252649b1fe9f0b30431a07ee0e8c8.tar.gz
[gwp_asan] Exclude recoverable tests on Fuchsia am: 92529f313e
Original change: https://android-review.googlesource.com/c/platform/external/gwp_asan/+/2569410 Change-Id: I4cc461386529186503ad50b963d1d9e6678fe8e2 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
-rw-r--r--gwp_asan/tests/backtrace.cpp4
-rw-r--r--gwp_asan/tests/harness.cpp7
2 files changed, 9 insertions, 2 deletions
diff --git a/gwp_asan/tests/backtrace.cpp b/gwp_asan/tests/backtrace.cpp
index 7cbbcf5..6a84a2a 100644
--- a/gwp_asan/tests/backtrace.cpp
+++ b/gwp_asan/tests/backtrace.cpp
@@ -21,7 +21,7 @@ TEST_P(BacktraceGuardedPoolAllocatorDeathTest, DoubleFree) {
DeathRegex.append("was deallocated.*DeallocateMemory[^2].*");
DeathRegex.append("was allocated.*AllocateMemory");
if (!Recoverable) {
- ASSERT_DEATH(DeallocateMemory2(GPA, Ptr), DeathRegex);
+ EXPECT_DEATH(DeallocateMemory2(GPA, Ptr), DeathRegex);
return;
}
@@ -51,7 +51,7 @@ TEST_P(BacktraceGuardedPoolAllocatorDeathTest, UseAfterFree) {
DeathRegex.append("was allocated.*AllocateMemory");
if (!Recoverable) {
- ASSERT_DEATH(TouchMemory(Ptr), DeathRegex);
+ EXPECT_DEATH(TouchMemory(Ptr), DeathRegex);
return;
}
diff --git a/gwp_asan/tests/harness.cpp b/gwp_asan/tests/harness.cpp
index 6d41630..4633d3e 100644
--- a/gwp_asan/tests/harness.cpp
+++ b/gwp_asan/tests/harness.cpp
@@ -47,8 +47,15 @@ void CheckOnlyOneGwpAsanCrash(const std::string &OutputBuffer) {
<< OutputBuffer;
}
+// Fuchsia does not support recoverable GWP-ASan.
+#if defined(__Fuchsia__)
+INSTANTIATE_TEST_SUITE_P(RecoverableAndNonRecoverableTests,
+ BacktraceGuardedPoolAllocatorDeathTest,
+ /* Recoverable */ testing::Values(false));
+#else
INSTANTIATE_TEST_SUITE_P(RecoverableTests, BacktraceGuardedPoolAllocator,
/* Recoverable */ testing::Values(true));
INSTANTIATE_TEST_SUITE_P(RecoverableAndNonRecoverableTests,
BacktraceGuardedPoolAllocatorDeathTest,
/* Recoverable */ testing::Bool());
+#endif