diff options
| author | Caslyn Tonelli <caslyn@google.com> | 2023-04-19 00:07:30 +0000 |
|---|---|---|
| committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2023-04-19 00:07:30 +0000 |
| commit | 3d67343ede5580ae8042fc592038535e0f15ef91 (patch) | |
| tree | 2b94fc60a93247d1e8b0239e1811e739ca0402b1 | |
| parent | 12af113cb74d592c262abfa0ec170f1bd7071a4d (diff) | |
| parent | 343a3e1fbc19a44d6f6fdfc6cae38ccc7f32e790 (diff) | |
| download | gwp_asan-3d67343ede5580ae8042fc592038535e0f15ef91.tar.gz | |
[gwp_asan] Employ EXPECT_DEATH for zxtest compatibility am: 343a3e1fbc
Original change: https://android-review.googlesource.com/c/platform/external/gwp_asan/+/2544985
Change-Id: I743a4a64522dec1b49182654ddebb103bfdb7aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
| -rw-r--r-- | gwp_asan/tests/harness.h | 7 | ||||
| -rw-r--r-- | gwp_asan/tests/never_allocated.cpp | 2 |
2 files changed, 8 insertions, 1 deletions
diff --git a/gwp_asan/tests/harness.h b/gwp_asan/tests/harness.h index 3e85935..ae39a44 100644 --- a/gwp_asan/tests/harness.h +++ b/gwp_asan/tests/harness.h @@ -15,6 +15,13 @@ #define ZXTEST_USE_STREAMABLE_MACROS #include <zxtest/zxtest.h> namespace testing = zxtest; +// zxtest defines a different ASSERT_DEATH, taking a lambda and an error message +// if death didn't occur, versus gtest taking a statement and a string to search +// for in the dying process. zxtest doesn't define an EXPECT_DEATH, so we use +// that in the tests below (which works as intended for gtest), and we define +// EXPECT_DEATH as a wrapper for zxtest's ASSERT_DEATH. Note that zxtest drops +// the functionality for checking for a particular message in death. +#define EXPECT_DEATH(X, Y) ASSERT_DEATH(([&] { X; }), "") #else #include "gtest/gtest.h" #endif diff --git a/gwp_asan/tests/never_allocated.cpp b/gwp_asan/tests/never_allocated.cpp index bd43b22..2f695b4 100644 --- a/gwp_asan/tests/never_allocated.cpp +++ b/gwp_asan/tests/never_allocated.cpp @@ -25,7 +25,7 @@ TEST_P(BacktraceGuardedPoolAllocatorDeathTest, NeverAllocated) { // in the posix crash handler. char *volatile NeverAllocatedPtr = static_cast<char *>(Ptr) + 0x3000; if (!Recoverable) { - ASSERT_DEATH(*NeverAllocatedPtr = 0, DeathNeedle); + EXPECT_DEATH(*NeverAllocatedPtr = 0, DeathNeedle); return; } |