Age | Commit message (Collapse) | Author |
|
Backport #36601 to v1.63.
Needed to backport #36686
|
|
configuration (#36674) (#36687)
Backport #36674 to 1.63.x
|
|
Backport https://github.com/grpc/grpc/pull/36664 to 1.63
|
|
(#36532)
Backport of #36450 to v1.63.x.
---
Integrates the new features of the the Kokoro PSM Interop install
library introduced in grpc/psm-interop#73.
Nearly all common functionality was moved from per-language/per-branch
PSM Interop build scripts to
[psm_interop_kokoro_lib.sh](https://github.com/grpc/psm-interop/blob/main/.kokoro/psm_interop_kokoro_lib.sh):
1. The list of tests in the each test suite
2. Per-test-suite flag customization
3. `run_test` methods
4. `build_docker_images_if_needed` methods
5. Generic `build_test_app_docker_images` methods (simple docker build +
docker push + docker tag). grpc-java is one exception, as it doesn't run
docker directly, but a cloudbuild flow.
Now all PSM Interop jobs share the same buildscripts by all test suites:
1. buildscript that invokes the test: `psm-interop-test-{language}.sh`
(configured as `build_file` in the build cfg)
2. buildscript that builds the xDS test client/server and publishes them
as a Docker image: `psm-interop-build-{language}.sh` (conventional name
called from `psm_interop_kokoro_lib.sh`)
`psm-interop-test-{language}.sh`:
1. Sets `GRPC_LANGUAGE`, `BUILD_SCRIPT_DIR` environment variables.
2. Downloads the shared `psm_interop_kokoro_lib.sh` from the main branch
of the psm-interop repo.
3. Sources `psm-interop-build-{language}.sh`
4. Calls `psm::run "${PSM_TEST_SUITE}"` (`PSM_TEST_SUITE` configured in
the cfg file).
`psm-interop-build-{language}.sh`:
1. Defines `psm::lang::build_docker_images` which is called from
`psm_interop_kokoro_lib.sh`.
2. Invokes any repo-specific logic.
3. May use `psm::build::docker_images_generic` for generic Docker build,
tag, push, or provide implement its own build/publish method.
References:
- b/288578634
- See the full list of the new features at grpc/psm-interop#73.
- Additional fixes to the shared lib: grpc/psm-interop#78,
grpc/psm-interop#79
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
Absl logging was made the default in #36121. This is a behavior change
since absl logging doesn't use the same configuration that gpr logging
does (for example, `GRPC_VERBOSITY`).
Disabling absl logging for the release branch since we haven't had a
gRFC for this change.
|
|
Backport of #36352 to v1.63.x.
---
`setuptools` made a decision to change the artifact name it builds (from
`grpcio-health-checking` to `grpcio_health_checking`) in their latest
release (https://github.com/pypa/setuptools/issues/4300).
As a result, we need broaden our regex so that our tests can pickup the
correct files.
### Note
* Using `[_-]*` instead of `[_-]?` to match one character since `bash`
uses a different flavor of regular expressions called basic regular
expressions (BREs) which do not support the optional quantifier `?`.
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
|
|
Backport of https://github.com/grpc/grpc/pull/36323 and
https://github.com/grpc/grpc/pull/36230
---------
Co-authored-by: Xuan Wang <xuanwn@google.com>
|
|
`https://github.com/grpc/grpc/commit/e510ff89aa38d9c9243b4446474c1335ee1b9f54` to `v1.63.x` (#36344)
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
from `debug` (#36325)
|
|
Change was created by the release automation script. See go/grpc-release.
Closes #36293
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36293 from yijiem:bump_core_version_202404081658 b306ec1e6982b4cd0fbc9f2efaa9b93a28029cc8
PiperOrigin-RevId: 623338846
|
|
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36305
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36305 from ginayeh:go_release 6eb1f2cdc1afb4dad246298cd2dc5587e04e4671
PiperOrigin-RevId: 623317762
|
|
Closes #36276
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36276 from ctiller:port_platform-include-grpcpp-clang-format 324257753042129f795e03574d8a4cb58be72c26
PiperOrigin-RevId: 623302430
|
|
Closes #36278
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36278 from ctiller:port_platform-include-grpc++-impl-clang-format d49bba38bb62de0f8fc9a34810f85abb3ade3093
PiperOrigin-RevId: 623302426
|
|
nogil (#36266)
This fix is similar to https://github.com/grpc/grpc/pull/34712 but for `grpc_google_default_credentials_create` rather than `grpc_ssl_credentials_create`
Fixes https://github.com/grpc/grpc/issues/36265
Fixes https://github.com/googleapis/python-bigtable/issues/949
Closes #36266
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36266 from parthea:repro-issue-34672 d736f6f080c27a0eddc71b97d2d9b26f81b30e29
PiperOrigin-RevId: 623291826
|
|
PanCakes to the rescue!
We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that!
If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml
Closes #36309
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36309 from grpc:create-pull-request/patch-4feb98e f76f2493ab6fad8cc8e4f2ec3b27f16edec7ce71
PiperOrigin-RevId: 623277186
|
|
This fixes rare failure under MSAN. This does not increate the test run time:
MSAN build:
```
//test/cpp/interop:backend_metrics_lb_policy_test@poller=poll PASSED in 59.2s
Stats over 5000 runs: max = 59.2s, min = 4.9s, avg = 6.5s, dev = 2.8s
```
Opt/no MSAN:
```
//test/cpp/interop:backend_metrics_lb_policy_test@poller=poll PASSED in 26.7s
Stats over 5000 runs: max = 26.7s, min = 4.9s, avg = 7.7s, dev = 2.8s
```
Closes #36308
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36308 from eugeneo:333396468-msan-backend_metrics_lb_policy_test 4ad9443131e2cbe50a0c214dbba93cfc7dd7db60
PiperOrigin-RevId: 623250444
|
|
Typo introduced in: https://github.com/grpc/grpc/pull/34450
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
|
|
- Added Visual C++ 2022 test to Windows C/C++ test set
- Windows potability test is now running two tests
- CMake / Ninja / Visual C++ 2019 on x86
- CMake / MSBuild / Visual C++ 2022 on x64
Closes #36236
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36236 from veblush:vc2022 100085366f449cb519f4816052ccc83c5f3b5c1a
PiperOrigin-RevId: 623244062
|
|
As per [gRFC A71](https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md).
Closes #36145
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36145 from eugeneo:fallback-review 4871c0b316e1a67ee63b4da12c1f5e65b9ca20b7
PiperOrigin-RevId: 623211613
|
|
Migrate PSM Interop images from Container Registry (gcr.io) to Artifact Registry (pkg.dev).
Closes #36273
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36273 from sergiitk:psm-interop-pkg-dev a831ad48bb467d7303cb705ca832c4c3928eadcc
PiperOrigin-RevId: 623209428
|
|
Closes #36235
PiperOrigin-RevId: 623204716
|
|
Updates to `CallFilter` to get it ready for integration to `CallSpine`.
This is a bundle commit grabbed from my working branch so there's a few things rolled in here:
* PipeState picks up methods to close it cleanly and in error, and expands its Pull API to signify that error
* Add a `NextMessage` type that encapsulates one message pulled from a pipe (much like `Pipe::NextResult` - except that we know this is a message, and it's built on the `CallFilters` types)
* Add debug stringifiers to many CallFilters types, and better tracing
* Eliminate unused `CallFilters::PipePromise::Pull` type -- other variants are better for all cases
* Add support for filters having the signature `(Handle, Filter*) -> promise returning StatusOr<Handle>` - will support `ClientAuthFilter` in a future commit asynchronously mutating client initial metadata
Closes #36240
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36240 from ctiller:cally-1 aa5fe997bf7b037925d2f8a0099ec9e2c1e0471b
PiperOrigin-RevId: 623194327
|
|
Closes #36274
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36274 from ctiller:port_platform-include-grpc-clang-format e368acfad9ba00b401ed3483ccee7fe29f50c351
PiperOrigin-RevId: 623182400
|
|
Closes #36275
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36275 from ctiller:port_platform-include-grpcpp-impl-clang-format 89c43491d0ff4385c24c235854ab220d923307b1
PiperOrigin-RevId: 623178498
|
|
Closes #36281
PiperOrigin-RevId: 623176865
|
|
Closes #36277
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36277 from ctiller:port_platform-include-grpcpp-impl-codegen-clang-format 2670fb8c35ef741c778abd2338fea826b4cfe224
PiperOrigin-RevId: 623176416
|
|
Closes #36279
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36279 from ctiller:port_platform-include-grpcpp-security-clang-format fc03b264c0daadedcbe3f08bca8819a7dee5f3f5
PiperOrigin-RevId: 623176265
|
|
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36283
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36283 from ctiller:port_platform-src-compiler-clang-format e5289caa6a719963d0d886167588fae5f5178f3d
PiperOrigin-RevId: 623176077
|
|
Closes #36252
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36252 from arvindbr8:go_release_1.61.2 d5e69b79b57af080a2b109e4f9fb1023dc8cbb53
PiperOrigin-RevId: 623169766
|
|
The build layout I chose in https://github.com/grpc/grpc/pull/36198 causes problems for Google's internal build systems. This change fixes things so that link order is correct - unfortunately at the cost of adding 90-some C++ compilations.
I've made a new .cc file that is as minimal as possible to reduce the cost of those compilations down as far as I can.
PiperOrigin-RevId: 623012695
|
|
Closes #36251
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36251 from arvindbr8:go_release_1.62.2 470fb3752abe01a8959546f78093740d7b163523
PiperOrigin-RevId: 622992946
|
|
PiperOrigin-RevId: 622991342
|
|
PiperOrigin-RevId: 622990471
|
|
Closes #35579
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35579 from ctiller:use-downcast 6f11268751fb2190ee1142ce5d321e2f0bb4347f
PiperOrigin-RevId: 622981017
|
|
per-attempt metrics (#36254)
As per https://github.com/grpc/proposal/pull/419, the experimental optional label `grpc.lb.locality` is added to the follow per-call metrics -
* grpc.client.attempt.duration
* grpc.client.attempt.sent_total_compressed_message_size
* grpc.client.attempt.rcvd_total_compressed_message_size
Closes #36254
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36254 from yashykt:OTelOptionalLabelsOnPerCall c5390c99a11c854bb15bb86434d38ec7329719e8
PiperOrigin-RevId: 622973959
|
|
Closes #35957
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35957 from drfloob:endpoint-infusion abdb9939c5bbed459182495f6272965aed8ecca8
PiperOrigin-RevId: 622939183
|
|
### NOTE
* We shouldn't merge this PR until GCP cloud functions drops support for Python 3.7 ([Currently scheduled for GCF](https://cloud.google.com/functions/docs/runtime-support#python))
As part of supporting Python 3.12, we're now officially drop support for Python 3.7.
This PR:
* Changed supported Python version from 3.7 to 3.8 in README.
* Replaced distribution test image from `debian:buster` to `debian:bullseye` since the default Python version in buster is 3.7.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #34450
PiperOrigin-RevId: 622899511
|
|
Fix: https://github.com/grpc/grpc/issues/26498
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36214
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36214 from XuanWang-Amos:fix_aio_Metadata_class 90329a2bdf4d99e5c358f5c0ac3414dfd75e18a9
PiperOrigin-RevId: 622898840
|
|
(#36223)
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK
Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites.
This could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 4000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36223
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36223 from tanvi-jagtap:assert_grpclb 205ba1d023979dd7c3bd990a8da1161d4d2f38de
PiperOrigin-RevId: 622378411
|
|
`ChannelInitDeathTest.CanAddBeforeAllTwice` (#36263)
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36263
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36263 from yijiem:fix-tests-1.63-release 205746bdbd19a48daa90bf185131a1b8aa9ff00f
PiperOrigin-RevId: 622251682
|
|
PDB files are consuming a significant amount of storage space on our Windows test machines. With each PDB file being around 200MB and every target having its own corresponding file, the disk usage adds up quickly.
Fortunately, we can address this issue without sacrificing debugging functionality. [Shrink my Program Database (PDB) file](https://devblogs.microsoft.com/cppblog/shrink-my-program-database-pdb-file/) outlines several techniques to reduce PDB file size. We can implement these methods to achieve our goal. (From my experiment, the compression option only can reduce a 200MB PDB file by 60%)
This change only picks options which don't reduce debuggability.
Closes #36259
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36259 from veblush:pdbdiet 5781a789b684dea9e383a741040a98f093388887
PiperOrigin-RevId: 622232176
|
|
Seeing the following error in the [grpc_portability](https://fusion2.corp.google.com/ci;ids=1930537984/kokoro/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_portability/activity/3abaaa26-ee47-4ae6-a7ca-29c42e92857a/tests) build:
```
2024-04-05 04:25:38,790 WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1712290838.800474 1083330 config.cc:239] gRPC experiments: work_serializer_dispatch:off; default-enabled: call_status_override_on_cancellation, event_engine_dns, event_engine_listener, http2_stats_fix, monitoring_experiment, pending_queue_cap, work_serializer_clears_time_cache
I0000 00:00:1712290838.800793 1083330 ev_epoll1_linux.cc:123] grpc epoll fd: 3
Note: Google Test filter = ServiceConfigParserTest.DoubleRegistration
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ServiceConfigParserTest
[ RUN ] ServiceConfigParserTest.DoubleRegistration
[WARNING] /var/local/git/grpc/third_party/googletest/googletest/src/gtest-death-test.cc:1102:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 4 threads. See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions, especially if this is the last message you see before your test times o
ut.
2024-04-05 04:25:38,791 TIMEOUT: cmake/build/service_config_test --gtest_filter=ServiceConfigParserTest.DoubleRegistration GRPC_POLL_STRATEGY=epoll1 [pid=1083328, time=300.0sec]
```
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36261
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36261 from yijiem:fix-tests-1.63-release 5605defcba1c892e4f6e677e2b81f5540c943497
PiperOrigin-RevId: 622222161
|
|
interop client image (#36253)
[Python Client] Verified by manually trigger test including the new session drain test:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/60ee9457-6c4a-4c13-ab01-f8370d499cca)
[Python Client] With `app_net_ssa_test`:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/5a928e0d-6b81-418a-8817-a0739d9796d6)
[Python Client And Server] All psm-csm tests:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/7d064c41-7759-41de-9ae1-099d5ec05797)
- Note we're using C++ 1.62.x image for session drain test server.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36253
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36253 from XuanWang-Amos:add_python_ssa_drain_test 1befc499ed3a229d30558d1bf8afcc3093e442a2
PiperOrigin-RevId: 622219139
|
|
https://fusion2.corp.google.com/ci/kokoro/prod:grpc%2Fcore%2Fexperimental%2Flinux%2Fgrpc_interop_matrix_adhoc/activity/a7576ab2-9c63-4dad-b595-17bdcbf6596e/log
Closes #36260
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36260 from YifeiZhuang:release-163 913768db9913e5ea69307c2c9378de18f82bb257
PiperOrigin-RevId: 622195832
|
|
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36182
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36182 from yijiem:grpc-metrics-async-gauge 8614485f3dddb514b0fbda4977e1425f41312984
PiperOrigin-RevId: 622182710
|
|
PiperOrigin-RevId: 621996203
|
|
Closes #36246
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36246 from ananda1066:exps 128795c35d5183d3935103aec946973a3f81ca1e
PiperOrigin-RevId: 621994634
|