aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Boström <pbos@chromium.org>2024-01-29 09:09:39 -0800
committerPeter Boström <pbos@chromium.org>2024-01-30 17:27:36 +0000
commit6551ac3632eb7236642366f70a2eb865b87a3329 (patch)
tree9123cc4bff738f6986b3ab3dfba243dd68929ef8
parent38365ae4ec3a5fec5a1ead13bcaa0025b32cbb24 (diff)
downloadgoogle-breakpad-6551ac3632eb7236642366f70a2eb865b87a3329.tar.gz
Fix uninitialized report_warnings in Mac dump_syms
This uninitialized-memory use breaks the Mac ubsan build as dump_syms runs during the build step. Bug: chromium:1324701 Change-Id: Id4e0a7d38893b2ceb49e58d1f5c99a056d84a921 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5243705 Reviewed-by: Lei Zhang <thestig@chromium.org>
-rw-r--r--src/tools/mac/dump_syms/dump_syms_tool.cc26
1 files changed, 8 insertions, 18 deletions
diff --git a/src/tools/mac/dump_syms/dump_syms_tool.cc b/src/tools/mac/dump_syms/dump_syms_tool.cc
index ded4c10e..cd8e565d 100644
--- a/src/tools/mac/dump_syms/dump_syms_tool.cc
+++ b/src/tools/mac/dump_syms/dump_syms_tool.cc
@@ -55,29 +55,19 @@ using google_breakpad::scoped_ptr;
using std::vector;
struct Options {
- Options()
- : srcPath(),
- dsymPath(),
- arch(),
- header_only(false),
- cfi(true),
- handle_inter_cu_refs(true),
- handle_inlines(false),
- enable_multiple(false),
- module_name(),
- prefer_extern_name(false) {}
+ Options() = default;
string srcPath;
string dsymPath;
std::optional<ArchInfo> arch;
- bool header_only;
- bool cfi;
- bool handle_inter_cu_refs;
- bool handle_inlines;
- bool enable_multiple;
+ bool header_only = false;
+ bool cfi = true;
+ bool handle_inter_cu_refs = true;
+ bool handle_inlines = false;
+ bool enable_multiple = false;
string module_name;
- bool prefer_extern_name;
- bool report_warnings;
+ bool prefer_extern_name = false;
+ bool report_warnings = false;
};
static bool StackFrameEntryComparator(const Module::StackFrameEntry* a,