diff options
| author | Nicholas Junge <nicholas.junge@web.de> | 2024-01-18 14:35:57 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-18 13:35:57 +0000 |
| commit | 4682db08bc7bb7e547e0a1056e32392998f8101f (patch) | |
| tree | e6cc4d628ce5ad84dfc3828be19a1bb9ebb1e18f | |
| parent | 3d293cd67a264701378c46e2ae3b6408d533e093 (diff) | |
| download | google-benchmark-4682db08bc7bb7e547e0a1056e32392998f8101f.tar.gz | |
Bump pre-commit dependencies (#1740)
Also fix a mypy error in `tools.gbench.util` - the condition behaves the
same as before, but in the new mypy version, the old condition results
in an unreachable code error for the final `return False` statement.
This is most likely a bug in mypy's reachability analysis, but the fix
is easy enough here to circumvent it.
| -rw-r--r-- | .pre-commit-config.yaml | 4 | ||||
| -rw-r--r-- | tools/gbench/util.py | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index a58a5cf..0247d1b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -5,13 +5,13 @@ repos: - id: buildifier - id: buildifier-lint - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.7.1 + rev: v1.8.0 hooks: - id: mypy types_or: [ python, pyi ] args: [ "--ignore-missing-imports", "--scripts-are-modules" ] - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.1.7 + rev: v0.1.13 hooks: - id: ruff args: [ --fix, --exit-non-zero-on-fix ] diff --git a/tools/gbench/util.py b/tools/gbench/util.py index 84747d1..d49018a 100644 --- a/tools/gbench/util.py +++ b/tools/gbench/util.py @@ -131,9 +131,7 @@ def load_benchmark_results(fname, benchmark_filter): if benchmark_filter is None: return True name = benchmark.get("run_name", None) or benchmark["name"] - if re.search(benchmark_filter, name): - return True - return False + return re.search(benchmark_filter, name) is not None with open(fname, "r") as f: results = json.load(f) |