diff options
| author | Li-Yu Yu <afg984@gmail.com> | 2024-01-05 18:27:12 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-05 10:27:12 +0000 |
| commit | 07c98d5a44908593c7e2fad1ab004aa1c3a234f3 (patch) | |
| tree | b81f2d61354402b3bd2285304fc920a42fa5e466 | |
| parent | e3824e7503187993b287ac8c8144a35bf5ccfd44 (diff) | |
| download | google-benchmark-07c98d5a44908593c7e2fad1ab004aa1c3a234f3.tar.gz | |
Avoid leaking LFS flags to reverse dependencies (#1730)
Follow up of #1725.
`defines` propagates to reverse dependencies, while `local_defines`
don't. If we use `defines` then there's risk of ODR violation:
Suppose a user have a cc_library foo that depends on bar and benchmark:
cc_library(name = "foo", deps = [":bar", "@com_github_google_benchmark//:benchmark"])
And bar has a class that has LFS-dependant ABI:
cc_library(name = "foo")
class Bar {
off_t member;
};
Bar would be compiled without LFS, but linked to foo when assuming LFS is enabled.
So we limit LFS to within the library only. benchmark does not have
LFS dependant public ABIs so it should be fine.
| -rw-r--r-- | BUILD.bazel | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/BUILD.bazel b/BUILD.bazel index c51cd89..0178e2c 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -51,10 +51,6 @@ cc_library( }), defines = [ "BENCHMARK_STATIC_DEFINE", - # Turn on Large-file Support - "_FILE_OFFSET_BITS=64", - "_LARGEFILE64_SOURCE", - "_LARGEFILE_SOURCE", ] + select({ ":perfcounters": ["HAVE_LIBPFM"], "//conditions:default": [], @@ -67,6 +63,12 @@ cc_library( # Using `defines` (i.e. not `local_defines`) means that no # dependent rules need to bother about defining the macro. linkstatic = True, + local_defines = [ + # Turn on Large-file Support + "_FILE_OFFSET_BITS=64", + "_LARGEFILE64_SOURCE", + "_LARGEFILE_SOURCE", + ], strip_include_prefix = "include", visibility = ["//visibility:public"], deps = select({ |