From c5a18079642440aee3ac32f81dfbda441303650f Mon Sep 17 00:00:00 2001 From: Jason Macnak Date: Thu, 30 Mar 2023 09:17:49 -0700 Subject: Reland: Use "gfxstream" namespace This reverts commit 5d733516cbc2d636c716fe0f24ad05cfbef80855. Reland adds in aosp/2514000 which was only built on the "full" target. Bug: b/271464937 Test: android build Test: cmake build Change-Id: I480285e32d44f27bcc8068d3e010c7f10c4bfabe --- registry/vulkan/scripts/cereal/decoder.py | 25 +++++++++++++++++++---- registry/vulkan/scripts/cereal/decodersnapshot.py | 2 +- registry/vulkan/scripts/cereal/encoder.py | 2 +- registry/vulkan/scripts/cerealgenerator.py | 18 ++++++++++++---- 4 files changed, 37 insertions(+), 10 deletions(-) diff --git a/registry/vulkan/scripts/cereal/decoder.py b/registry/vulkan/scripts/cereal/decoder.py index 3e826c90..6c7ee38c 100644 --- a/registry/vulkan/scripts/cereal/decoder.py +++ b/registry/vulkan/scripts/cereal/decoder.py @@ -26,8 +26,13 @@ global_state_prefix = "m_state->on_" decoder_decl_preamble = """ -class ProcessResources; +namespace gfxstream { class IOStream; +class ProcessResources; +} // namespace gfxstream + +namespace gfxstream { +namespace vk { class VkDecoder { public: @@ -40,14 +45,18 @@ private: class Impl; std::unique_ptr mImpl; }; + +} // namespace vk +} // namespace gfxstream + """ decoder_impl_preamble =""" +namespace gfxstream { +namespace vk { + using android::base::MetricEventBadPacketLength; using android::base::MetricEventDuplicateSequenceNum; -using emugl::vkDispatch; - -using namespace goldfish_vk; class VkDecoder::Impl { public: @@ -104,6 +113,13 @@ size_t VkDecoder::decode(void* buf, size_t bufsize, IOStream* stream, // VkDecoder::Impl::decode to follow """ % (VULKAN_STREAM_TYPE, VULKAN_STREAM_TYPE) +decoder_impl_postamble = """ + +} // namespace vk +} // namespace gfxstream + +""" + READ_STREAM = "vkReadStream" WRITE_STREAM = "vkStream" @@ -897,3 +913,4 @@ size_t VkDecoder::Impl::decode(void* buf, size_t len, IOStream* ioStream, self.cgen.stmt("return ptr - (unsigned char*)buf;") self.cgen.endBlock() # function body self.module.appendImpl(self.cgen.swapCode()) + self.module.appendImpl(decoder_impl_postamble) diff --git a/registry/vulkan/scripts/cereal/decodersnapshot.py b/registry/vulkan/scripts/cereal/decodersnapshot.py index f4dc6d6f..4ff97a1d 100644 --- a/registry/vulkan/scripts/cereal/decodersnapshot.py +++ b/registry/vulkan/scripts/cereal/decodersnapshot.py @@ -39,7 +39,7 @@ private: decoder_snapshot_impl_preamble =""" -using namespace goldfish_vk; +using namespace gfxstream::vk; using emugl::GfxApiLogger; using emugl::HealthMonitor; diff --git a/registry/vulkan/scripts/cereal/encoder.py b/registry/vulkan/scripts/cereal/encoder.py index 108d1228..d3e39745 100644 --- a/registry/vulkan/scripts/cereal/encoder.py +++ b/registry/vulkan/scripts/cereal/encoder.py @@ -38,7 +38,7 @@ private: encoder_impl_preamble =""" -using namespace goldfish_vk; +using namespace gfxstream::vk; using android::base::guest::AutoLock; using android::base::guest::Lock; diff --git a/registry/vulkan/scripts/cerealgenerator.py b/registry/vulkan/scripts/cerealgenerator.py index ad5aab71..988cda45 100644 --- a/registry/vulkan/scripts/cerealgenerator.py +++ b/registry/vulkan/scripts/cerealgenerator.py @@ -325,11 +325,13 @@ using android::base::BumpPool; dispatchHeaderDefs = f""" {self.hostCommonExtraVulkanHeaders} #include "goldfish_vk_private_defs.h" -namespace goldfish_vk {{ +namespace gfxstream {{ +namespace vk {{ struct VulkanDispatch; -}} // namespace goldfish_vk +}} // namespace vk +}} // namespace gfxstream using DlOpenFunc = void* (void); using DlSymFunc = void* (void*, const char*); """ @@ -652,8 +654,16 @@ class BumpPool; autogeneratedHeaderTemplate % \ (basename, "(header) generated by %s" % banner_command(sys.argv)) - namespaceBegin = "namespace goldfish_vk {" if useNamespace else "" - namespaceEnd = "} // namespace goldfish_vk" if useNamespace else "" + + namespaceBegin = """ +namespace gfxstream { +namespace vk { +""" if useNamespace else "" + + namespaceEnd = """ +} // namespace vk" +} // namespace gfxstream +""" if useNamespace else "" module.headerPreamble += "#pragma once\n" if (not suppressVulkanHeaders): -- cgit v1.2.3