diff options
author | Diego Novillo <dnovillo@google.com> | 2022-09-21 15:52:34 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-21 15:52:34 -0400 |
commit | 21146c1b4ba48ea8eb66e6ca9afbe31c70d78f14 (patch) | |
tree | 0325e77f55220c80ac536c561553009f0299f53f | |
parent | aeb1c64d4ab7105ea981d3076d5f47a88a0ccb2d (diff) | |
download | SPIRV-Tools-21146c1b4ba48ea8eb66e6ca9afbe31c70d78f14.tar.gz |
Fix builtin validator for unimplemented opcodes. (#4940)
This prevents spurious build failures when new opcodeds are added in
SPIRV-Headers. It moves all the unhandled opcodes to the `default`
case.
-rw-r--r-- | source/val/validate_builtins.cpp | 39 |
1 files changed, 3 insertions, 36 deletions
diff --git a/source/val/validate_builtins.cpp b/source/val/validate_builtins.cpp index 40a36d06..d5b89eb1 100644 --- a/source/val/validate_builtins.cpp +++ b/source/val/validate_builtins.cpp @@ -4280,48 +4280,15 @@ spv_result_t BuiltInsValidator::ValidateSingleBuiltInAtDefinition( case SpvBuiltInCullMaskKHR: { return ValidateRayTracingBuiltinsAtDefinition(decoration, inst); } - case SpvBuiltInWorkDim: - case SpvBuiltInGlobalSize: - case SpvBuiltInEnqueuedWorkgroupSize: - case SpvBuiltInGlobalOffset: - case SpvBuiltInGlobalLinearId: - case SpvBuiltInSubgroupMaxSize: - case SpvBuiltInNumEnqueuedSubgroups: - case SpvBuiltInBaryCoordNoPerspAMD: - case SpvBuiltInBaryCoordNoPerspCentroidAMD: - case SpvBuiltInBaryCoordNoPerspSampleAMD: - case SpvBuiltInBaryCoordSmoothAMD: - case SpvBuiltInBaryCoordSmoothCentroidAMD: - case SpvBuiltInBaryCoordSmoothSampleAMD: - case SpvBuiltInBaryCoordPullModelAMD: - case SpvBuiltInViewportMaskNV: - case SpvBuiltInSecondaryPositionNV: - case SpvBuiltInSecondaryViewportMaskNV: - case SpvBuiltInPositionPerViewNV: - case SpvBuiltInViewportMaskPerViewNV: - case SpvBuiltInMax: - case SpvBuiltInTaskCountNV: - case SpvBuiltInPrimitiveCountNV: - case SpvBuiltInPrimitiveIndicesNV: - case SpvBuiltInClipDistancePerViewNV: - case SpvBuiltInCullDistancePerViewNV: - case SpvBuiltInLayerPerViewNV: - case SpvBuiltInMeshViewCountNV: - case SpvBuiltInMeshViewIndicesNV: - case SpvBuiltInCurrentRayTimeNV: - case SpvBuiltInPrimitivePointIndicesEXT: - case SpvBuiltInPrimitiveLineIndicesEXT: - case SpvBuiltInPrimitiveTriangleIndicesEXT: - case SpvBuiltInCullPrimitiveEXT: - // No validation rules (for the moment). - break; - case SpvBuiltInPrimitiveShadingRateKHR: { return ValidatePrimitiveShadingRateAtDefinition(decoration, inst); } case SpvBuiltInShadingRateKHR: { return ValidateShadingRateAtDefinition(decoration, inst); } + default: + // No validation rules (for the moment). + break; } return SPV_SUCCESS; } |