summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorminyue@webrtc.org <minyue@webrtc.org>2014-10-30 07:46:47 +0000
committerminyue@webrtc.org <minyue@webrtc.org>2014-10-30 07:46:47 +0000
commit2f5b8b6ff1228e277abcd4079131600c7ec3b92f (patch)
tree604c3fa948e8457ac169cdc53e9c0bd114306eff
parentd19bf752e3237e01d3d9db7372f2f123d20929d6 (diff)
downloadtalk-2f5b8b6ff1228e277abcd4079131600c7ec3b92f.tar.gz
Revert 7564 "to submit" due to wrong submission
> to submit TBR=minyue@webrtc.org Review URL: https://webrtc-codereview.appspot.com/23289004 git-svn-id: http://webrtc.googlecode.com/svn/trunk/talk@7565 4adac7df-926f-26a2-2b94-8c16560cd09d
-rw-r--r--media/webrtc/webrtcvoiceengine_unittest.cc41
1 files changed, 13 insertions, 28 deletions
diff --git a/media/webrtc/webrtcvoiceengine_unittest.cc b/media/webrtc/webrtcvoiceengine_unittest.cc
index 5deabd2..7e38183 100644
--- a/media/webrtc/webrtcvoiceengine_unittest.cc
+++ b/media/webrtc/webrtcvoiceengine_unittest.cc
@@ -1254,12 +1254,9 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOpusMaxPlaybackRateNb) {
webrtc::CodecInst gcodec;
EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
EXPECT_STREQ("opus", gcodec.plname);
-
- EXPECT_EQ(12000, gcodec.rate);
- codecs[0].SetParam(cricket::kCodecParamStereo, "1");
- EXPECT_TRUE(channel_->SetSendCodecs(codecs));
- EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
- EXPECT_EQ(24000, gcodec.rate);
+ // TODO(minyue): Default bit rate is not but can in future be affected by
+ // kCodecParamMaxPlaybackRate.
+ EXPECT_EQ(32000, gcodec.rate);
}
// Test 8000 < maxplaybackrate <= 12000 triggers Opus medium band mode.
@@ -1276,12 +1273,9 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOpusMaxPlaybackRateMb) {
webrtc::CodecInst gcodec;
EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
EXPECT_STREQ("opus", gcodec.plname);
-
- EXPECT_EQ(20000, gcodec.rate);
- codecs[0].SetParam(cricket::kCodecParamStereo, "1");
- EXPECT_TRUE(channel_->SetSendCodecs(codecs));
- EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
- EXPECT_EQ(40000, gcodec.rate);
+ // TODO(minyue): Default bit rate is not but can in future be affected by
+ // kCodecParamMaxPlaybackRate.
+ EXPECT_EQ(32000, gcodec.rate);
}
// Test 12000 < maxplaybackrate <= 16000 triggers Opus wide band mode.
@@ -1298,12 +1292,9 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOpusMaxPlaybackRateWb) {
webrtc::CodecInst gcodec;
EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
EXPECT_STREQ("opus", gcodec.plname);
-
- EXPECT_EQ(20000, gcodec.rate);
- codecs[0].SetParam(cricket::kCodecParamStereo, "1");
- EXPECT_TRUE(channel_->SetSendCodecs(codecs));
- EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
- EXPECT_EQ(40000, gcodec.rate);
+ // TODO(minyue): Default bit rate is not but can in future be affected by
+ // kCodecParamMaxPlaybackRate.
+ EXPECT_EQ(32000, gcodec.rate);
}
// Test 16000 < maxplaybackrate <= 24000 triggers Opus super wide band mode.
@@ -1320,12 +1311,9 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOpusMaxPlaybackRateSwb) {
webrtc::CodecInst gcodec;
EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
EXPECT_STREQ("opus", gcodec.plname);
-
+ // TODO(minyue): Default bit rate is not but can in future be affected by
+ // kCodecParamMaxPlaybackRate.
EXPECT_EQ(32000, gcodec.rate);
- codecs[0].SetParam(cricket::kCodecParamStereo, "1");
- EXPECT_TRUE(channel_->SetSendCodecs(codecs));
- EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
- EXPECT_EQ(64000, gcodec.rate);
}
// Test 24000 < maxplaybackrate triggers Opus full band mode.
@@ -1342,12 +1330,9 @@ TEST_F(WebRtcVoiceEngineTestFake, SetOpusMaxPlaybackRateFb) {
webrtc::CodecInst gcodec;
EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
EXPECT_STREQ("opus", gcodec.plname);
-
+ // TODO(minyue): Default bit rate is not but can in future be affected by
+ // kCodecParamMaxPlaybackRate.
EXPECT_EQ(32000, gcodec.rate);
- codecs[0].SetParam(cricket::kCodecParamStereo, "1");
- EXPECT_TRUE(channel_->SetSendCodecs(codecs));
- EXPECT_EQ(0, voe_.GetSendCodec(channel_num, gcodec));
- EXPECT_EQ(64000, gcodec.rate);
}
// Test Opus that without maxplaybackrate, default playback rate is used.