1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2017 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////
package com.puppycrawl.tools.checkstyle.checks.naming;
import static com.puppycrawl.tools.checkstyle.checks.naming.AbstractNameCheck.MSG_INVALID_PATTERN;
import static com.puppycrawl.tools.checkstyle.checks.naming.MethodNameCheck.MSG_KEY;
import static org.junit.Assert.assertArrayEquals;
import org.junit.Test;
import com.puppycrawl.tools.checkstyle.AbstractModuleTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
import com.puppycrawl.tools.checkstyle.utils.CommonUtils;
public class MethodNameCheckTest
extends AbstractModuleTestSupport {
@Override
protected String getPackageLocation() {
return "com/puppycrawl/tools/checkstyle/checks/naming/methodname";
}
@Test
public void testGetRequiredTokens() {
final MethodNameCheck checkObj = new MethodNameCheck();
final int[] expected = {TokenTypes.METHOD_DEF};
assertArrayEquals("Default required tokens are invalid",
expected, checkObj.getRequiredTokens());
}
@Test
public void testDefault()
throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
final String pattern = "^[a-z][a-zA-Z0-9]*$";
final String[] expected = {
"137:10: " + getCheckMessage(MSG_INVALID_PATTERN, "ALL_UPPERCASE_METHOD", pattern),
};
verify(checkConfig, getPath("InputMethodNameSimple.java"), expected);
}
@Test
public void testMethodEqClass() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
final String pattern = "^[a-z][a-zA-Z0-9]*$";
final String[] expected = {
"12:16: " + getCheckMessage(MSG_KEY, "InputMethodNameEqualClassName"),
"12:16: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"17:17: " + getCheckMessage(MSG_INVALID_PATTERN, "PRIVATEInputMethodNameEqualClassName",
pattern),
"23:20: " + getCheckMessage(MSG_KEY, "Inner"),
"23:20: " + getCheckMessage(MSG_INVALID_PATTERN, "Inner", pattern),
"28:20: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"37:24: " + getCheckMessage(MSG_KEY, "InputMethodNameEqualClassName"),
"37:24: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"47:9: " + getCheckMessage(MSG_KEY, "SweetInterface"),
"47:9: " + getCheckMessage(MSG_INVALID_PATTERN, "SweetInterface", pattern),
"53:17: " + getCheckMessage(MSG_KEY, "Outter"),
"53:17: " + getCheckMessage(MSG_INVALID_PATTERN, "Outter", pattern),
};
verify(checkConfig, getPath("InputMethodNameEqualClassName.java"), expected);
}
@Test
public void testMethodEqClassAllow() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
// allow method names and class names to equal
checkConfig.addAttribute("allowClassName", "true");
final String pattern = "^[a-z][a-zA-Z0-9]*$";
final String[] expected = {
"12:16: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"17:17: " + getCheckMessage(MSG_INVALID_PATTERN, "PRIVATEInputMethodNameEqualClassName",
pattern),
"23:20: " + getCheckMessage(MSG_INVALID_PATTERN, "Inner", pattern),
"28:20: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"37:24: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"47:9: " + getCheckMessage(MSG_INVALID_PATTERN, "SweetInterface", pattern),
"53:17: " + getCheckMessage(MSG_INVALID_PATTERN, "Outter", pattern),
};
verify(checkConfig, getPath("InputMethodNameEqualClassName.java"), expected);
}
@Test
public void testAccessTuning() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
// allow method names and class names to equal
checkConfig.addAttribute("allowClassName", "true");
// allow method names and class names to equal
checkConfig.addAttribute("applyToPrivate", "false");
final String pattern = "^[a-z][a-zA-Z0-9]*$";
final String[] expected = {
"12:16: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"23:20: " + getCheckMessage(MSG_INVALID_PATTERN, "Inner", pattern),
"28:20: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"37:24: " + getCheckMessage(MSG_INVALID_PATTERN,
"InputMethodNameEqualClassName", pattern),
"47:9: " + getCheckMessage(MSG_INVALID_PATTERN, "SweetInterface", pattern),
"53:17: " + getCheckMessage(MSG_INVALID_PATTERN, "Outter", pattern),
};
verify(checkConfig, getPath("InputMethodNameEqualClassName.java"), expected);
}
@Test
public void testForNpe() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
final String[] expected = CommonUtils.EMPTY_STRING_ARRAY;
verify(checkConfig, getPath("InputMethodNameExtra.java"), expected);
}
@Test
public void testOverriddenMethods() throws Exception {
final DefaultConfiguration checkConfig =
createModuleConfig(MethodNameCheck.class);
final String pattern = "^[a-z][a-zA-Z0-9]*$";
final String[] expected = {
"17:17: " + getCheckMessage(MSG_INVALID_PATTERN, "PUBLICfoo", pattern),
"20:20: " + getCheckMessage(MSG_INVALID_PATTERN, "PROTECTEDfoo", pattern),
};
verify(checkConfig, getPath("InputMethodNameOverridenMethods.java"), expected);
}
@Test
public void testGetAcceptableTokens() {
final MethodNameCheck methodNameCheckObj = new MethodNameCheck();
final int[] actual = methodNameCheckObj.getAcceptableTokens();
final int[] expected = {
TokenTypes.METHOD_DEF,
};
assertArrayEquals("Default acceptable tokens are invalid", expected, actual);
}
}
|
