aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUebelAndre <github@uebelandre.com>2023-09-22 09:45:20 -0700
committerGitHub <noreply@github.com>2023-09-22 16:45:20 +0000
commitaf75f6e7ad9df277cc92c0c61e4a4cd486c65869 (patch)
tree44b0cf9fda99fcc6bffa33806429b4e9bc2f0e80
parent7d1cc0950fbe4e71e1f1472442b13bc7d92ccc43 (diff)
downloadbazelbuild-rules_rust-af75f6e7ad9df277cc92c0c61e4a4cd486c65869.tar.gz
Revert "Flip experimental_use_coverage_metadata_files" (#2164)
Reverts bazelbuild/rules_rust#2128. It was a bit preemptive to flip the flag for a version of bazel that was _just_ released. This revert can be reverted in the future when Bazel 6.3 has aged a bit more. closes https://github.com/bazelbuild/rules_rust/issues/2146
-rw-r--r--.bazelci/presubmit.yml6
-rw-r--r--rust/settings/BUILD.bazel2
2 files changed, 1 insertions, 7 deletions
diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
index d5ce63c0..4cf55ba3 100644
--- a/.bazelci/presubmit.yml
+++ b/.bazelci/presubmit.yml
@@ -223,9 +223,6 @@ tasks:
# If updating the minimum bazel version, please also update /docs/index.md
bazel: "6.3.0"
platform: ubuntu1804
- # Disable use of `instrumented_files_info.metadata_files` until Bazel 6.3 is the min version
- shell_commands:
- - echo 'build --//rust/settings:experimental_use_coverage_metadata_files=false' > user.bazelrc
build_targets: *default_linux_targets
test_targets: *default_linux_targets
coverage_targets: *default_linux_targets
@@ -234,9 +231,6 @@ tasks:
name: "Min Bazel Version With Aspects"
bazel: "6.3.0"
platform: ubuntu1804
- # Disable use of `instrumented_files_info.metadata_files` until Bazel 6.3 is the min version
- shell_commands:
- - echo 'build --//rust/settings:experimental_use_coverage_metadata_files=false' > user.bazelrc
build_targets: *default_linux_targets
test_targets: *default_linux_targets
build_flags: *aspects_flags
diff --git a/rust/settings/BUILD.bazel b/rust/settings/BUILD.bazel
index 367077a6..0cf12538 100644
--- a/rust/settings/BUILD.bazel
+++ b/rust/settings/BUILD.bazel
@@ -56,7 +56,7 @@ bool_flag(
# reporting tools like `llvm-cov` and `llvm-profdata` as runfiles to each test.
bool_flag(
name = "experimental_use_coverage_metadata_files",
- build_setting_default = True,
+ build_setting_default = False,
)
bzl_library(