aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuben Rodriguez Buchillon <coconutruben@chromium.org>2022-05-16 11:31:57 -0700
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2022-05-27 03:31:29 +0000
commit669d28ca0994aa8f7734d3c94fd831bb18011abf (patch)
tree4d824389b131f5d6d9c913e13032b6435124fd4a
parent6483f4e26bbc700fa834e652c83d5d027439b3a2 (diff)
downloadautotest-669d28ca0994aa8f7734d3c94fd831bb18011abf.tar.gz
power_test: run browsers with --disable-features=FirmwareUpdaterApp
The fwupd might restart powerd, and we want to make sure that powerd stays off as to not interfere with our brightness settings. BUG=b:228256145 // 1st test: tot TEST=test_that --autotest_dir $dname localhost:10000 power_VideoPlayback.noarc // ssh onto the DUT while true; do sleep 1; status powerd; done powerd start/running, process 17898 [...] powerd start/running, process 17898 powerd stop/waiting powerd stop/waiting powerd start/running, process 19888 // it had been restarted [...] // 2nd test: tot + this fix TEST=test_that --autotest_dir $dname localhost:10000 power_VideoPlayback.noarc // ssh onto the DUT while true; do sleep 1; status powerd; done powerd start/running, process 14416 [...] powerd start/running, process 14416 powerd stop/waiting powerd stop/waiting [...] powerd stop/waiting powerd stop/waiting // it did not restart [...] Change-Id: Iced1da59e3051fa5c73a99a4797f7e70d959659d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/3651177 Tested-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Auto-Submit: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
-rw-r--r--client/cros/power/power_videotest.py2
-rw-r--r--client/site_tests/power_Display/power_Display.py2
-rwxr-xr-xclient/site_tests/power_Idle/power_Idle.py2
-rwxr-xr-xclient/site_tests/power_LoadTest/power_LoadTest.py2
-rw-r--r--client/site_tests/power_Speedometer2/power_Speedometer2.py8
-rw-r--r--client/site_tests/power_ThermalLoad/power_ThermalLoad.py8
-rw-r--r--client/site_tests/power_VideoEncode/power_VideoEncode.py2
7 files changed, 24 insertions, 2 deletions
diff --git a/client/cros/power/power_videotest.py b/client/cros/power/power_videotest.py
index b2b708ae24..1a49348d49 100644
--- a/client/cros/power/power_videotest.py
+++ b/client/cros/power/power_videotest.py
@@ -108,6 +108,8 @@ class power_VideoTest(power_test.power_Test):
# --disable-sync disables test account info sync, eg. Wi-Fi credentials,
# so that each test run does not remember info from last test run.
extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
if not use_hw_decode:
extra_browser_args.append(self._DISABLE_HW_VIDEO_DECODE_ARGS)
diff --git a/client/site_tests/power_Display/power_Display.py b/client/site_tests/power_Display/power_Display.py
index 8822006b14..f702b1b60c 100644
--- a/client/site_tests/power_Display/power_Display.py
+++ b/client/site_tests/power_Display/power_Display.py
@@ -44,6 +44,8 @@ class power_Display(power_test.power_Test):
# --disable-sync disables test account info sync, eg. Wi-Fi credentials,
# so that each test run does not remember info from last test run.
extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
with chrome.Chrome(init_network_controller=True,
extra_browser_args=extra_browser_args) as self.cr:
tab = self.cr.browser.tabs[0]
diff --git a/client/site_tests/power_Idle/power_Idle.py b/client/site_tests/power_Idle/power_Idle.py
index bc93c0b548..5f56190907 100755
--- a/client/site_tests/power_Idle/power_Idle.py
+++ b/client/site_tests/power_Idle/power_Idle.py
@@ -61,6 +61,8 @@ class power_Idle(power_test.power_Test):
# --disable-sync disables test account info sync, eg. Wi-Fi credentials,
# so that each test run does not remember info from last test run.
extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
with chrome.Chrome(extra_browser_args=extra_browser_args,
arc_mode=self._arc_mode) as self.cr:
self.is_first_test = True
diff --git a/client/site_tests/power_LoadTest/power_LoadTest.py b/client/site_tests/power_LoadTest/power_LoadTest.py
index b1cc99e125..4fe0887f0c 100755
--- a/client/site_tests/power_LoadTest/power_LoadTest.py
+++ b/client/site_tests/power_LoadTest/power_LoadTest.py
@@ -332,6 +332,8 @@ class power_LoadTest(arc.ArcTest):
# --disable-sync disables test account info sync, eg. Wi-Fi credentials,
# so that each test run does not remember info from last test run.
extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
try:
self._browser = chrome.Chrome(
extension_paths=[ext_path],
diff --git a/client/site_tests/power_Speedometer2/power_Speedometer2.py b/client/site_tests/power_Speedometer2/power_Speedometer2.py
index 04d30f01a4..40ae3edecf 100644
--- a/client/site_tests/power_Speedometer2/power_Speedometer2.py
+++ b/client/site_tests/power_Speedometer2/power_Speedometer2.py
@@ -31,7 +31,13 @@ class power_Speedometer2(power_test.power_Test):
@param url: url of Speedometer2 test page.
"""
- with chrome.Chrome(init_network_controller=True) as self.cr:
+ # --disable-sync disables test account info sync, eg. Wi-Fi credentials,
+ # so that each test run does not remember info from last test run.
+ extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
+ with chrome.Chrome(extra_browser_args=extra_browser_args,
+ init_network_controller=True) as self.cr:
tab = self.cr.browser.tabs[0]
tab.Activate()
diff --git a/client/site_tests/power_ThermalLoad/power_ThermalLoad.py b/client/site_tests/power_ThermalLoad/power_ThermalLoad.py
index 832b8106bb..8099a0b16c 100644
--- a/client/site_tests/power_ThermalLoad/power_ThermalLoad.py
+++ b/client/site_tests/power_ThermalLoad/power_ThermalLoad.py
@@ -52,7 +52,13 @@ class power_ThermalLoad(power_test.power_Test):
@param duration: time in seconds to display url and measure power.
@param numFish: number of fish to pass to WebGL Aquarium.
"""
- with chrome.Chrome(init_network_controller=True) as self.cr:
+ # --disable-sync disables test account info sync, eg. Wi-Fi credentials,
+ # so that each test run does not remember info from last test run.
+ extra_browser_args = ['--disable-sync']
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
+ with chrome.Chrome(extra_browser_args=extra_browser_args,
+ init_network_controller=True) as self.cr:
tab = self.cr.browser.tabs.New()
tab.Activate()
diff --git a/client/site_tests/power_VideoEncode/power_VideoEncode.py b/client/site_tests/power_VideoEncode/power_VideoEncode.py
index d585f3b0fa..bed2a7c5c8 100644
--- a/client/site_tests/power_VideoEncode/power_VideoEncode.py
+++ b/client/site_tests/power_VideoEncode/power_VideoEncode.py
@@ -49,6 +49,8 @@ class power_VideoEncode(power_test.power_Test):
Format is tuple of codec, resolution and framerate.
"""
extra_browser_args = self.get_extra_browser_args_for_camera_test()
+ # b/228256145 to avoid powerd restart
+ extra_browser_args.append('--disable-features=FirmwareUpdaterApp')
with chrome.Chrome(init_network_controller=True,
extra_browser_args=extra_browser_args) as cr: