1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
|
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package org.apache.commons.compress.archivers.zip;
import static org.junit.Assert.*;
import org.junit.Before;
import org.junit.Test;
import java.util.zip.ZipException;
/**
* JUnit testcases for org.apache.commons.compress.archivers.zip.ExtraFieldUtils.
*
*/
public class ExtraFieldUtilsTest implements UnixStat {
/**
* Header-ID of a ZipExtraField not supported by Commons Compress.
*
* <p>Used to be ZipShort(1) but this is the ID of the Zip64 extra
* field.</p>
*/
static final ZipShort UNRECOGNIZED_HEADER = new ZipShort(0x5555);
private AsiExtraField a;
private UnrecognizedExtraField dummy;
private byte[] data;
private byte[] aLocal;
@Before
public void setUp() {
a = new AsiExtraField();
a.setMode(0755);
a.setDirectory(true);
dummy = new UnrecognizedExtraField();
dummy.setHeaderId(UNRECOGNIZED_HEADER);
dummy.setLocalFileDataData(new byte[] {0});
dummy.setCentralDirectoryData(new byte[] {0});
aLocal = a.getLocalFileDataData();
final byte[] dummyLocal = dummy.getLocalFileDataData();
data = new byte[4 + aLocal.length + 4 + dummyLocal.length];
System.arraycopy(a.getHeaderId().getBytes(), 0, data, 0, 2);
System.arraycopy(a.getLocalFileDataLength().getBytes(), 0, data, 2, 2);
System.arraycopy(aLocal, 0, data, 4, aLocal.length);
System.arraycopy(dummy.getHeaderId().getBytes(), 0, data,
4+aLocal.length, 2);
System.arraycopy(dummy.getLocalFileDataLength().getBytes(), 0, data,
4+aLocal.length+2, 2);
System.arraycopy(dummyLocal, 0, data,
4+aLocal.length+4, dummyLocal.length);
}
/**
* test parser.
*/
@Test
public void testParse() throws Exception {
final ZipExtraField[] ze = ExtraFieldUtils.parse(data);
assertEquals("number of fields", 2, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
assertTrue("type field 2", ze[1] instanceof UnrecognizedExtraField);
assertEquals("data length field 2", 1,
ze[1].getLocalFileDataLength().getValue());
final byte[] data2 = new byte[data.length-1];
System.arraycopy(data, 0, data2, 0, data2.length);
try {
ExtraFieldUtils.parse(data2);
fail("data should be invalid");
} catch (final Exception e) {
assertEquals("message",
"bad extra field starting at "+(4 + aLocal.length)
+ ". Block length of 1 bytes exceeds remaining data of 0 bytes.",
e.getMessage());
}
}
@Test
public void parseTurnsArrayIndexOutOfBoundsIntoZipException() throws Exception {
AsiExtraField f = new AsiExtraField();
f.setLinkedFile("foo");
byte[] l = f.getLocalFileDataData();
// manipulate size of path name to read 4 rather than 3
l[9] = 4;
// and fake CRC so we actually reach the AIOBE
l[0] = (byte) 0x52;
l[1] = (byte) 0x26;
l[2] = (byte) 0x18;
l[3] = (byte) 0x19;
byte[] d = new byte[4 + l.length];
System.arraycopy(f.getHeaderId().getBytes(), 0, d, 0, 2);
System.arraycopy(f.getLocalFileDataLength().getBytes(), 0, d, 2, 2);
System.arraycopy(l, 0, d, 4, l.length);
try {
ExtraFieldUtils.parse(d);
fail("data should be invalid");
} catch (final ZipException e) {
assertEquals("message",
"Failed to parse corrupt ZIP extra field of type 756e",
e.getMessage());
}
}
@Test
public void testParseCentral() throws Exception {
final ZipExtraField[] ze = ExtraFieldUtils.parse(data,false);
assertEquals("number of fields", 2, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
assertTrue("type field 2", ze[1] instanceof UnrecognizedExtraField);
assertEquals("data length field 2", 1,
ze[1].getCentralDirectoryLength().getValue());
}
@Test
public void testParseWithRead() throws Exception {
ZipExtraField[] ze =
ExtraFieldUtils.parse(data, true,
ExtraFieldUtils.UnparseableExtraField.READ);
assertEquals("number of fields", 2, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
assertTrue("type field 2", ze[1] instanceof UnrecognizedExtraField);
assertEquals("data length field 2", 1,
ze[1].getLocalFileDataLength().getValue());
final byte[] data2 = new byte[data.length-1];
System.arraycopy(data, 0, data2, 0, data2.length);
ze = ExtraFieldUtils.parse(data2, true,
ExtraFieldUtils.UnparseableExtraField.READ);
assertEquals("number of fields", 2, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
assertTrue("type field 2", ze[1] instanceof UnparseableExtraFieldData);
assertEquals("data length field 2", 4,
ze[1].getLocalFileDataLength().getValue());
for (int i = 0; i < 4; i++) {
assertEquals("byte number " + i,
data2[data.length - 5 + i],
ze[1].getLocalFileDataData()[i]);
}
}
@Test
public void testParseWithSkip() throws Exception {
ZipExtraField[] ze =
ExtraFieldUtils.parse(data, true,
ExtraFieldUtils.UnparseableExtraField.SKIP);
assertEquals("number of fields", 2, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
assertTrue("type field 2", ze[1] instanceof UnrecognizedExtraField);
assertEquals("data length field 2", 1,
ze[1].getLocalFileDataLength().getValue());
final byte[] data2 = new byte[data.length-1];
System.arraycopy(data, 0, data2, 0, data2.length);
ze = ExtraFieldUtils.parse(data2, true,
ExtraFieldUtils.UnparseableExtraField.SKIP);
assertEquals("number of fields", 1, ze.length);
assertTrue("type field 1", ze[0] instanceof AsiExtraField);
assertEquals("mode field 1", 040755,
((AsiExtraField) ze[0]).getMode());
}
/**
* Test merge methods
*/
@Test
public void testMerge() {
final byte[] local =
ExtraFieldUtils.mergeLocalFileDataData(new ZipExtraField[] {a, dummy});
assertEquals("local length", data.length, local.length);
for (int i=0; i<local.length; i++) {
assertEquals("local byte "+i, data[i], local[i]);
}
final byte[] dummyCentral = dummy.getCentralDirectoryData();
final byte[] data2 = new byte[4 + aLocal.length + 4 + dummyCentral.length];
System.arraycopy(data, 0, data2, 0, 4 + aLocal.length + 2);
System.arraycopy(dummy.getCentralDirectoryLength().getBytes(), 0,
data2, 4+aLocal.length+2, 2);
System.arraycopy(dummyCentral, 0, data2,
4+aLocal.length+4, dummyCentral.length);
final byte[] central =
ExtraFieldUtils.mergeCentralDirectoryData(new ZipExtraField[] {a, dummy});
assertEquals("central length", data2.length, central.length);
for (int i=0; i<central.length; i++) {
assertEquals("central byte "+i, data2[i], central[i]);
}
}
@Test
public void testMergeWithUnparseableData() throws Exception {
final ZipExtraField d = new UnparseableExtraFieldData();
final byte[] b = UNRECOGNIZED_HEADER.getBytes();
d.parseFromLocalFileData(new byte[] {b[0], b[1], 1, 0}, 0, 4);
final byte[] local =
ExtraFieldUtils.mergeLocalFileDataData(new ZipExtraField[] {a, d});
assertEquals("local length", data.length - 1, local.length);
for (int i = 0; i < local.length; i++) {
assertEquals("local byte " + i, data[i], local[i]);
}
final byte[] dCentral = d.getCentralDirectoryData();
final byte[] data2 = new byte[4 + aLocal.length + dCentral.length];
System.arraycopy(data, 0, data2, 0, 4 + aLocal.length + 2);
System.arraycopy(dCentral, 0, data2,
4 + aLocal.length, dCentral.length);
final byte[] central =
ExtraFieldUtils.mergeCentralDirectoryData(new ZipExtraField[] {a, d});
assertEquals("central length", data2.length, central.length);
for (int i = 0; i < central.length; i++) {
assertEquals("central byte " + i, data2[i], central[i]);
}
}
}
|
