summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLi-Yu Yu <aaronyu@google.com>2024-05-06 12:18:42 +0000
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>2024-05-09 03:43:47 +0000
commit25cd2f51a566ec3678957979c55b49112eaf638a (patch)
tree7190ee61af8bb37d18948bc812e8a955c3f5ad67
parentcdbaa39af3a5edcb84851bb42e388625f983f621 (diff)
downloadadhd-25cd2f51a566ec3678957979c55b49112eaf638a.tar.gz
Don't print numeric values of active_ap_effects
The bit values are not the same as the "effects" bits and confuses people. BUG=b:311612899 TEST=CQ Change-Id: I99807a7781a49584aad107eb542bb18370e73937 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/5514347 Commit-Queue: Li-Yu Yu <aaronyu@google.com> Reviewed-by: Pattara Teerapong <pteerapong@chromium.org> Tested-by: chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com <chromeos-cop-builder@chromeos-cop.iam.gserviceaccount.com>
-rw-r--r--cras/client/cras-sys/src/lib.rs3
-rw-r--r--cras/deprecated/cras_test_client/cras_test_client.c3
2 files changed, 2 insertions, 4 deletions
diff --git a/cras/client/cras-sys/src/lib.rs b/cras/client/cras-sys/src/lib.rs
index 46a36ead..e6bd4198 100644
--- a/cras/client/cras-sys/src/lib.rs
+++ b/cras/client/cras-sys/src/lib.rs
@@ -732,8 +732,7 @@ impl fmt::Display for AudioStreamDebugInfo {
writeln!(f, " Effects: {:#x}", self.effects)?;
writeln!(
f,
- " Active AP effects: {:#x} = {}",
- self.active_ap_effects,
+ " Active AP effects: {}",
CRAS_STREAM_ACTIVE_AP_EFFECT::from_bits_truncate(self.active_ap_effects).joined_name()
)?;
writeln!(f, " Frame rate: {}", self.frame_rate)?;
diff --git a/cras/deprecated/cras_test_client/cras_test_client.c b/cras/deprecated/cras_test_client/cras_test_client.c
index 188826d2..5d954de7 100644
--- a/cras/deprecated/cras_test_client/cras_test_client.c
+++ b/cras/deprecated/cras_test_client/cras_test_client.c
@@ -1196,8 +1196,7 @@ static void print_aligned_audio_debug_info(const struct audio_debug_info* info,
(unsigned int)info->streams[i].cb_threshold,
(unsigned int)info->streams[i].effects);
- printf("active_ap_effects: 0x%" PRIx64 " = ",
- info->streams[i].active_ap_effects);
+ printf("active_ap_effects: ");
print_cras_stream_active_ap_effects(stdout,
info->streams[i].active_ap_effects);
printf("\n");