diff options
| author | Stefano Cianciulli <scianciulli@google.com> | 2023-06-20 12:52:38 +0000 |
|---|---|---|
| committer | Stefano Cianciulli <scianciulli@google.com> | 2023-06-20 13:00:04 +0000 |
| commit | f86e97a606930ca4c8b043b752f4a7f853e64359 (patch) | |
| tree | a9f012c3028f8e5c4122c3e188fb8fc43011b985 | |
| parent | 739c60f891e991f85069d0d38c4035a9e7dfa9b8 (diff) | |
| download | art-f86e97a606930ca4c8b043b752f4a7f853e64359.tar.gz | |
Update default values for metrics flags to enable reporting from public am: 5bf0f68407 am: aa2c59af69 am: 65c6dd0a09 am: 16e7cfbf17 am: d416febde2 am: b0d3d8fd04
Original change: https://android-review.googlesource.com/c/platform/art/+/2629991
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d5777cdc1266545930b5f243934d77e0d1bb5869)
Bug: 229618060
Merged-In: I8e4ba7523da4331b3789cf788ea762f33b84d4f3
Change-Id: I8e4ba7523da4331b3789cf788ea762f33b84d4f3
| -rw-r--r-- | libartbase/base/flags.h | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/libartbase/base/flags.h b/libartbase/base/flags.h index 4c38fbaeec..4734a60568 100644 --- a/libartbase/base/flags.h +++ b/libartbase/base/flags.h @@ -263,22 +263,23 @@ struct Flags { // The reporting spec for regular apps. An example of valid value is "S,1,2,4,*". // See metrics::ReportingPeriodSpec for complete docs. - Flag<std::string> MetricsReportingSpec{"metrics.reporting-spec", "", FlagType::kDeviceConfig}; + Flag<std::string> MetricsReportingSpec{ + "metrics.reporting-spec", "1,5,30,60,600", FlagType::kDeviceConfig}; // The reporting spec for the system server. See MetricsReportingSpec as well. - Flag<std::string> MetricsReportingSpecSystemServer{"metrics.reporting-spec-server", "", - FlagType::kDeviceConfig}; + Flag<std::string> MetricsReportingSpecSystemServer{ + "metrics.reporting-spec-server", "1,10,60,3600,*", FlagType::kDeviceConfig}; // The mods that should report metrics. Together with MetricsReportingNumMods, they // dictate what percentage of the runtime execution will report metrics. // If the `session_id (a random number) % MetricsReportingNumMods < MetricsReportingMods` // then the runtime session will report metrics. // - // By default, the mods are 0, which means the reporting is disabled. - Flag<uint32_t> MetricsReportingMods{"metrics.reporting-mods", 0, - FlagType::kDeviceConfig}; - Flag<uint32_t> MetricsReportingModsServer{"metrics.reporting-mods-server", 0, - FlagType::kDeviceConfig}; + // By default, the mods are 2, which means that 2 out of #{reporting-num-mods} of Android sessions + // will be reported (with the default values this is 2/100 = 2%). + Flag<uint32_t> MetricsReportingMods{"metrics.reporting-mods", 2, FlagType::kDeviceConfig}; + Flag<uint32_t> MetricsReportingModsServer{ + "metrics.reporting-mods-server", 2, FlagType::kDeviceConfig}; // See MetricsReportingMods docs. // @@ -293,7 +294,7 @@ struct Flags { // Whether or not we should write metrics to statsd. // Note that the actual write is still controlled by // MetricsReportingMods and MetricsReportingNumMods. - Flag<bool> MetricsWriteToStatsd{ "metrics.write-to-statsd", false, FlagType::kDeviceConfig}; + Flag<bool> MetricsWriteToStatsd{"metrics.write-to-statsd", true, FlagType::kDeviceConfig}; // Whether or not we should write metrics to logcat. // Note that the actual write is still controlled by |