summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Rosenberg <drosen@google.com>2017-07-19 17:16:43 -0700
committerDaniel Rosenberg <drosen@google.com>2017-07-20 17:59:08 -0700
commit939568f95bc140d1ceb99d24e5c4001d2ffa75e4 (patch)
treefe9c5a9fac079a8d895fe03d65edd38e8afb68e7
parenta868e6e9f69d87e045a323754aedb6d38466fcca (diff)
downloadx86_64-939568f95bc140d1ceb99d24e5c4001d2ffa75e4.tar.gz
ANDROID: sdcardfs: Remove unnecessary lock
The mmap_sem lock does not appear to be protecting anything, and has been removed in Samsung's more recent versions of sdcardfs. Signed-off-by: Daniel Rosenberg <drosen@google.com> Change-Id: I76ff3e33002716b8384fc8be368028ed63dffe4e Bug: 63785372
-rwxr-xr-xfs/sdcardfs/inode.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/sdcardfs/inode.c b/fs/sdcardfs/inode.c
index f4d6c08df935..030210ac8e10 100755
--- a/fs/sdcardfs/inode.c
+++ b/fs/sdcardfs/inode.c
@@ -778,13 +778,9 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
* afterwards in the other cases: we fsstack_copy_inode_size from
* the lower level.
*/
- if (current->mm)
- down_write(&current->mm->mmap_sem);
if (ia->ia_valid & ATTR_SIZE) {
err = inode_newsize_ok(&tmp, ia->ia_size);
if (err) {
- if (current->mm)
- up_write(&current->mm->mmap_sem);
goto out;
}
truncate_setsize(inode, ia->ia_size);
@@ -807,8 +803,6 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
err = notify_change2(lower_mnt, lower_dentry, &lower_ia); /* note: lower_ia */
mutex_unlock(&lower_dentry->d_inode->i_mutex);
- if (current->mm)
- up_write(&current->mm->mmap_sem);
if (err)
goto out;