summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Llamas <cmllamas@google.com>2024-03-30 19:01:14 +0000
committermdb:android-git <superproject-auto-update@invalid>2024-04-01 18:11:56 +0000
commitf106c3c13befdc6584f2f9dca2279472044340fe (patch)
tree496ddba4fd13b81f768518b422e071357aae9ed3
parent422d555c3d3e1f04655c75022bb6a6c34b84cec0 (diff)
downloadsuperproject-f106c3c13befdc6584f2f9dca2279472044340fe.tar.gz
FROMLIST: binder: check offset alignment in binder_get_object()
Commit 6d98eb95b450 ("binder: avoid potential data leakage when copying txn") introduced changes to how binder objects are copied. In doing so, it unintentionally removed an offset alignment check done through calls to binder_alloc_copy_from_buffer() -> check_buffer(). These calls were replaced in binder_get_object() with copy_from_user(), so now an explicit offset alignment check is needed here. This avoids later complications when unwinding the objects gets harder. It is worth noting this check existed prior to commit 7a67a39320df ("binder: add function to copy binder object from buffer"), likely removed due to redundancy at the time. Fixes: 6d98eb95b450 ("binder: avoid potential data leakage when copying txn") Cc: <stable@vger.kernel.org> Acked-by: Todd Kjos <tkjos@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Bug: 320661088 Link: https://lore.kernel.org/all/20240330190115.1877819-1-cmllamas@google.com/ Signed-off-by: Carlos Llamas <cmllamas@google.com> Change-Id: Iaddabaa28de7ba7b7d35dbb639d38ca79dbc5077
m---------common0
1 files changed, 0 insertions, 0 deletions
diff --git a/common b/common
-Subproject afb3d0418799baa6aad92bf8a7d52fb84072b0a
+Subproject d76a750f6ffe72431a2c467e85a5ac69366287d