diff options
author | valis <sec@valis.email> | 2023-07-29 08:32:00 -0400 |
---|---|---|
committer | mdb:android-git <superproject-auto-update@invalid> | 2023-08-22 07:15:34 +0000 |
commit | 07d379dcc09cee4364183812df5f51b17bc0e16f (patch) | |
tree | 2a252668f8b5ba8285ff8fa027a522695bcf6c85 | |
parent | 6c26bc0aefa459ad9962a6148ec396f5570c2803 (diff) | |
download | superproject-07d379dcc09cee4364183812df5f51b17bc0e16f.tar.gz |
UPSTREAM: net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free
[ Upstream commit 3044b16e7c6fe5d24b1cdbcf1bd0a9d92d1ebd81 ]
When u32_change() is called on an existing filter, the whole
tcf_result struct is always copied into the new instance of the filter.
This causes a problem when updating a filter bound to a class,
as tcf_unbind_filter() is always called on the old instance in the
success path, decreasing filter_cnt of the still referenced class
and allowing it to be deleted, leading to a use-after-free.
Fix this by no longer copying the tcf_result struct from the old filter.
Bug: 296347075
Fixes: de5df63228fc ("net: sched: cls_u32 changes to knode must appear atomic to readers")
Reported-by: valis <sec@valis.email>
Reported-by: M A Ramdhan <ramdhan@starlabs.sg>
Signed-off-by: valis <sec@valis.email>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: M A Ramdhan <ramdhan@starlabs.sg>
Link: https://lore.kernel.org/r/20230729123202.72406-2-jhs@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit aab2d095ce4dd8d01ca484c0cc641fb497bf74db)
Signed-off-by: Lee Jones <joneslee@google.com>
Change-Id: I1a8381c308cc97cf61d6f95a02992d2c553455c5
m--------- | common | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/common b/common -Subproject e8c1340cbb0f24693dd9056f8d5a7808e4597b8 +Subproject 860ad2e6146b828479abeca3b96a5ecfc09f6ea |