summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAjay Davanageri <ajay.davanageri@broadcom.corp-partner.google.com>2023-07-05 19:08:40 +0530
committerTreehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com>2023-07-13 02:26:33 +0000
commit36fbe36e273a513ede1b169a17b3ff29994603e7 (patch)
treef61e642176a1380dd5cfa2b2dd47e349be571704
parentbb8298fc4afb851a2c0f803c15f9396a97e544ea (diff)
downloadbcm4398-36fbe36e273a513ede1b169a17b3ff29994603e7.tar.gz
dhd: Add debug logs for set apf filter failure
Bug:289294902 Test:Regression test passed. Change-Id: I5a8126eff81374d46e5116cbbd27db4c9fd6bc95 Signed-off-by: Ajay Davanageri <ajay.davanageri@broadcom.corp-partner.google.com>
-rw-r--r--dhd_linux.c4
-rw-r--r--wl_cfgvendor.c9
2 files changed, 13 insertions, 0 deletions
diff --git a/dhd_linux.c b/dhd_linux.c
index 895158b..f140315 100644
--- a/dhd_linux.c
+++ b/dhd_linux.c
@@ -17831,6 +17831,7 @@ dhd_dev_apf_add_filter(struct net_device *ndev, u8* program,
if (dhdp->apf_set) {
ret = _dhd_apf_delete_filter(ndev, PKT_FILTER_APF_ID);
if (unlikely(ret)) {
+ DHD_ERROR(("%s: Failed to delete APF filter\n", __FUNCTION__));
goto exit;
}
dhdp->apf_set = FALSE;
@@ -17838,6 +17839,7 @@ dhd_dev_apf_add_filter(struct net_device *ndev, u8* program,
ret = _dhd_apf_add_filter(ndev, PKT_FILTER_APF_ID, program, program_len);
if (ret) {
+ DHD_ERROR(("%s: Failed to add APF filter\n", __FUNCTION__));
goto exit;
}
dhdp->apf_set = TRUE;
@@ -17851,8 +17853,10 @@ dhd_dev_apf_add_filter(struct net_device *ndev, u8* program,
ret = _dhd_apf_config_filter(ndev, PKT_FILTER_APF_ID,
PKT_FILTER_MODE_FORWARD_ON_MATCH, TRUE);
if (ret) {
+ DHD_ERROR(("%s: Failed to config APF filter\n", __FUNCTION__));
goto exit;
}
+ DHD_ERROR(("%s: exit\n", __FUNCTION__));
}
exit:
DHD_APF_UNLOCK(ndev);
diff --git a/wl_cfgvendor.c b/wl_cfgvendor.c
index f949d1b..d2abec2 100644
--- a/wl_cfgvendor.c
+++ b/wl_cfgvendor.c
@@ -10320,6 +10320,8 @@ wl_cfgvendor_apf_set_filter(struct wiphy *wiphy,
int ret, tmp, type, max_len;
struct bcm_cfg80211 *cfg = wiphy_priv(wiphy);
+ WL_ERR(("%s: Enter\n", __FUNCTION__));
+
if (len <= 0) {
WL_ERR(("Invalid len: %d\n", len));
ret = -EINVAL;
@@ -10344,6 +10346,7 @@ wl_cfgvendor_apf_set_filter(struct wiphy *wiphy,
if (nla_len(iter) == sizeof(uint32) && !program_len) {
program_len = nla_get_u32(iter);
} else {
+ WL_ERR(("iter valid is not valid and program len is not 0\n"));
ret = -EINVAL;
goto exit;
}
@@ -10393,11 +10396,17 @@ wl_cfgvendor_apf_set_filter(struct wiphy *wiphy,
}
ret = dhd_dev_apf_add_filter(ndev, program, program_len);
+ if (unlikely(ret)) {
+ WL_ERR(("APF add filter failed, ret=%d\n", ret));
+ goto exit;
+ }
+ WL_INFORM_MEM(("Success to add APF filter program, program_len=%d\n", program_len));
exit:
if (program) {
MFREE(cfg->osh, program, program_len);
}
+ WL_ERR(("%s: Exit\n", __FUNCTION__));
return ret;
}