diff options
author | Alice Sheng <alicesheng@google.com> | 2022-01-18 11:19:46 -0800 |
---|---|---|
committer | Andrew Evans <andrewevans@google.com> | 2022-03-09 15:04:45 -0800 |
commit | 1b331b2ddab782e381eb99dee647ddbe31814d8d (patch) | |
tree | 5b72e467625f06a590aa37cc0926f266ba86e1c9 | |
parent | 42a3601e450f00564c1a64cd5e49d449169f7407 (diff) | |
download | rotary-encoders-1b331b2ddab782e381eb99dee647ddbe31814d8d.tar.gz |
Remove RSB Bank1 switching logic
If the device reboots when the RSB is in bank1, the RSB can get stuck in
a bad state. Also, the vendor recommends to not use those settings as
they were inherited from an older project.
Bug: 213228468
Change-Id: I17263dfbe023adedbca8a43cadf4d6c381470445
-rw-r--r-- | ots_pat9126/pat9126.c | 43 |
1 files changed, 0 insertions, 43 deletions
diff --git a/ots_pat9126/pat9126.c b/ots_pat9126/pat9126.c index fc9f635..2c62d5d 100644 --- a/ots_pat9126/pat9126.c +++ b/ots_pat9126/pat9126.c @@ -218,27 +218,6 @@ int pat9126_disable_mot(struct i2c_client *client, int16_t detect_freq) pat9126_read(client, PIXART_PAT9126_SENSOR_MODE_SELECT_REG, &tmp_1); pr_debug("[PAT9126]: Open drain mode motion: 0x%2x. \n", tmp_1); - /*Switch to bank1*/ - pat9126_write(client, PIXART_PAT9126_SELECT_BANK_REG, - PIXART_PAT9126_SELECT_BANK_VAL2); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_FTWK, - PIXART_PAT9126_BANK_FTWK_VAL1); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_FTWK_D2, - PIXART_PAT9126_BANK_FTWK_D2_VAL1); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_CTB, - PIXART_PAT9126_BANK_CTB_VAL1); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_HI_SAD_K, - PIXART_PAT9126_BANK_HI_SAD_K_VAL1); - - pat9126_write(client, PIXART_PAT9126_SELECT_BANK_REG, - PIXART_PAT9126_SELECT_BANK_VAL1); - - delay(1); /* delay 1ms */ - pat9126_write_verified(client, PIXART_PAT9126_SLEEP2_MODE_FREQ_REG, detect_freq); @@ -263,34 +242,12 @@ int pat9126_enable_mot(struct i2c_client *client) pat9126_read(client, PIXART_PAT9126_SENSOR_MODE_SELECT_REG, &tmp_1); pr_debug("[PAT9126]: Drive mode motion: 0x%2x. \n", tmp_1); - delay(1); /* delay 1ms */ - /*Read Register for Pulling Up Motion IRQ*/ pat9126_read(client, PIXART_PAT9126_MOTION_STATUS_REG, &tmp_1); pat9126_read(client, PIXART_PAT9126_DELTA_X_LO_REG, &tmp_1); pat9126_read(client, PIXART_PAT9126_DELTA_Y_LO_REG, &tmp_1); pat9126_read(client, PIXART_PAT9126_DELTA_XY_HI_REG, &tmp_1); - /*Write Register for Active Mode*/ - /*Switch to bank1*/ - pat9126_write(client, PIXART_PAT9126_SELECT_BANK_REG, - PIXART_PAT9126_SELECT_BANK_VAL2); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_FTWK, - PIXART_PAT9126_BANK_FTWK_DEFAULT_VAL); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_FTWK_D2, - PIXART_PAT9126_BANK_FTWK_D2_DEFAULT_VAL); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_CTB, - PIXART_PAT9126_BANK_CTB_DEFAULT_VAL); - - pat9126_write_verified(client, PIXART_PAT9126_BANK_HI_SAD_K, - PIXART_PAT9126_BANK_HI_SAD_K_DEFAULT_VAL); - - pat9126_write(client, PIXART_PAT9126_SELECT_BANK_REG, - PIXART_PAT9126_SELECT_BANK_VAL1); - delay(1); /* delay 1ms */ pat9126_write_verified(client, PIXART_PAT9126_SLEEP_MODE_SELECT_REG, |