summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHolmes Chou <holmeschou@google.com>2023-04-21 06:27:43 +0000
committerHolmes Chou <holmeschou@google.com>2023-04-21 07:07:53 +0000
commitd4c5dd6632128acbf16e8e121a7c96084fcfee42 (patch)
treea5846087d21fdb345906099162f4fd8a7980bd9b
parentb6a3a0459ca78bba006dfb25da1292e6f255d004 (diff)
downloadlwis-d4c5dd6632128acbf16e8e121a7c96084fcfee42.tar.gz
Revert "LWIS: print cleanup transaction read result"
This reverts commit 366c3d101edc49baf98f75a5dd5e2e43aba8bedf. Bug: 239873016 Test: GCA Change-Id: I81e869a7ce486394b335efdf3b323db74d125b26 Signed-off-by: Holmes Chou <holmeschou@google.com>
-rw-r--r--lwis_transaction.c63
1 files changed, 3 insertions, 60 deletions
diff --git a/lwis_transaction.c b/lwis_transaction.c
index 604b266..1a409d5 100644
--- a/lwis_transaction.c
+++ b/lwis_transaction.c
@@ -479,36 +479,12 @@ int lwis_transaction_client_flush(struct lwis_client *client)
return 0;
}
-static void print_buffer(struct lwis_client *client, const char *buf, int size)
-{
- char output_string[80], temp_string[8];
- int i;
-
- output_string[0] = '\0';
- for (i = 0; i < size; i++) {
- if (i % 16 == 0 && i != 0) {
- dev_info(client->lwis_dev->dev, "%s\n", output_string);
- output_string[0] = '\0';
- }
- sprintf(temp_string, "%02X ", buf[i]);
- if (i % 4 == 3) {
- strcat(temp_string, " ");
- }
- strcat(output_string, temp_string);
- }
- dev_info(client->lwis_dev->dev, "%s\n", output_string);
-}
-
int lwis_transaction_client_cleanup(struct lwis_client *client)
{
unsigned long flags;
struct list_head *it_tran, *it_tran_tmp;
struct lwis_transaction *transaction;
struct lwis_transaction_event_list *it_evt_list;
- struct list_head pending_events;
- struct lwis_event_entry *event;
-
- INIT_LIST_HEAD(&pending_events);
spin_lock_irqsave(&client->transaction_lock, flags);
/* Perform client defined clean-up routine. */
@@ -533,7 +509,9 @@ int lwis_transaction_client_cleanup(struct lwis_client *client)
cancel_transaction(client->lwis_dev, transaction, -ECANCELED, NULL, NULL);
} else {
spin_unlock_irqrestore(&client->transaction_lock, flags);
- process_transaction(client, transaction, &pending_events, NULL,
+ process_transaction(client, transaction,
+ /*pending_events=*/NULL,
+ /*pending_fences=*/NULL,
/*skip_err=*/true);
spin_lock_irqsave(&client->transaction_lock, flags);
}
@@ -542,41 +520,6 @@ int lwis_transaction_client_cleanup(struct lwis_client *client)
kfree(it_evt_list);
spin_unlock_irqrestore(&client->transaction_lock, flags);
-
- while (!list_empty(&pending_events)) {
- struct lwis_transaction_response_header *resp;
- struct lwis_io_result *result;
- char *results_buf;
- int i;
-
- event = list_first_entry(&pending_events, struct lwis_event_entry, node);
- /*
- If there is no read result, the payload size will less than
- sizeof(struct lwis_transaction_response_header).
- We can skip it.
- */
- if (event->event_info.payload_size <=
- sizeof(struct lwis_transaction_response_header)) {
- list_del(&event->node);
- kfree(event);
- continue;
- }
- resp = (struct lwis_transaction_response_header *)event->event_info.payload_buffer;
- dev_info(client->lwis_dev->dev, "event_id = %llx, num_entries = %ld\n",
- event->event_info.event_id, resp->num_entries);
- results_buf = (char *)event->event_info.payload_buffer +
- sizeof(struct lwis_transaction_response_header);
- for (i = 0; i < resp->num_entries; i++) {
- dev_info(client->lwis_dev->dev, "entry-%d\n", i);
- result = (struct lwis_io_result *)results_buf;
- print_buffer(client, result->values, result->num_value_bytes);
- results_buf += sizeof(struct lwis_io_result) + result->num_value_bytes;
- }
-
- list_del(&event->node);
- kfree(event);
- }
-
return 0;
}