diff options
author | Tomas Bortoli <tomasbortoli@gmail.com> | 2019-07-31 10:54:47 -0400 |
---|---|---|
committer | Todd Kjos <tkjos@google.com> | 2020-05-01 17:05:04 -0700 |
commit | 7e9c703d1e73fd902fec798a47f8068f25354c7d (patch) | |
tree | 5878edcd1ee515b3b17ac025732fe5c51319bfb4 | |
parent | 243a167c111d854943dafb15a1f3fe852be341e6 (diff) | |
download | goldfish-7e9c703d1e73fd902fec798a47f8068f25354c7d.tar.gz |
can: peak_usb: pcan_usb_pro: Fix info-leaks to USB devices
commit ead16e53c2f0ed946d82d4037c630e2f60f4ab69 upstream.
Uninitialized Kernel memory can leak to USB devices.
Fix by using kzalloc() instead of kmalloc() on the affected buffers.
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
Reported-by: syzbot+d6a5a1a3657b596ef132@syzkaller.appspotmail.com
Fixes: f14e22435a27 ("net: can: peak_usb: Do not do dma on the stack")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Change-Id: Ie4d53d2919ca8a416eda92a8df8f88a739baf530
-rw-r--r-- | drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c index f7f796a2c50b..9c4270185d6f 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c @@ -508,7 +508,7 @@ static int pcan_usb_pro_drv_loaded(struct peak_usb_device *dev, int loaded) u8 *buffer; int err; - buffer = kmalloc(PCAN_USBPRO_FCT_DRVLD_REQ_LEN, GFP_KERNEL); + buffer = kzalloc(PCAN_USBPRO_FCT_DRVLD_REQ_LEN, GFP_KERNEL); if (!buffer) return -ENOMEM; |