diff options
| author | Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2020-06-08 18:50:39 +0200 |
|---|---|---|
| committer | Shohei Sakamoto <sakamotos@casio.co.jp> | 2020-06-23 09:50:24 +0900 |
| commit | c6175e94b6c59d28bae1a43eeac566284b140a31 (patch) | |
| tree | f02a0e1162b4d85a1fe54e996b48c13dd9983bcf | |
| parent | bea716fd94193a154277b19ba8445bc58a51bf33 (diff) | |
| download | exynos-c6175e94b6c59d28bae1a43eeac566284b140a31.tar.gz | |
ALSA: pcm: disallow linking stream to itself
commit 951e2736f4b11b58dc44d41964fa17c3527d882a upstream.
Prevent SNDRV_PCM_IOCTL_LINK linking stream to itself - the code
can't handle it. Fixed commit is not where bug was introduced, but
changes the context significantly.
Cc: stable@vger.kernel.org
Fixes: 0888c321de70 ("pcm_native: switch to fdget()/fdput()")
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/89c4a2487609a0ed6af3ecf01cc972bdc59a7a2d.1591634956.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/core/pcm_native.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 59423576b1cc..8c0887d597bc 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -1836,6 +1836,11 @@ static int snd_pcm_link(struct snd_pcm_substream *substream, int fd) } pcm_file = f.file->private_data; substream1 = pcm_file->substream; + if (substream == substream1) { + res = -EINVAL; + goto _badf; + } + group = kmalloc(sizeof(*group), GFP_KERNEL); if (!group) { res = -ENOMEM; |